asm: add .note.GNU-stack section for non-exec stack #1441

pull fanquake wants to merge 1 commits into bitcoin-core:master from fanquake:avoid_exec_stack_ld changing 1 files +1 −0
  1. fanquake commented at 2:52 pm on November 13, 2023: member

    With this in place, we no-longer see warnings like the following:

    0/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: warning: field_10x26_arm.o: missing .note.GNU-stack section implies executable stack
    1/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
    

    Should close #1434.

  2. asm: add .note.GNU-stack section for non-exec stack
    With this in place, we no-longer see warnings like the following:
    ```bash
    /usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: warning: field_10x26_arm.o: missing .note.GNU-stack section implies executable stack
    /usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
    ```
    
    Should close #1434.
    33dc7e4d3e
  3. real-or-random approved
  4. real-or-random commented at 6:12 pm on November 13, 2023: contributor
    utACK 33dc7e4d3e1947af4c84c09ecc75ea2eeed3f7e0
  5. real-or-random commented at 6:14 pm on November 13, 2023: contributor

    With this in place, we no-longer see warnings like the following:

    Just for clarification: Is “you” Bitcoin Core? As far as I know, the ARM assembly shouldn’t be enabled there. (We still consider it experimental, though that’s a bit unfortunate because don’t have a plan for stabilizing it…)

  6. real-or-random added the label build on Nov 13, 2023
  7. real-or-random added the label refactor/smell on Nov 13, 2023
  8. fanquake commented at 6:16 pm on November 13, 2023: member

    Just for clarification: Is “you” Bitcoin Core?

    I only tested this within a local checkout of libsecp, not with Core/anywhere else.

  9. sipa commented at 2:31 pm on November 15, 2023: contributor
    utACK 33dc7e4d3e1947af4c84c09ecc75ea2eeed3f7e0
  10. real-or-random merged this on Nov 16, 2023
  11. real-or-random closed this on Nov 16, 2023

  12. fanquake deleted the branch on Nov 16, 2023
  13. hebasto commented at 10:22 am on November 16, 2023: member

    Post-merge ACK 33dc7e4d3e1947af4c84c09ecc75ea2eeed3f7e0.

    I only tested this within a local checkout of libsecp, not with Core/anywhere else.

    Tested for Bitcoin Core in the Guix build process, which includes security checks.

    Forcing --with-asm=arm32 causes a failure in the check_NX security test.

    This PR diff fixes it.

  14. real-or-random commented at 1:32 pm on November 16, 2023: contributor

    Forcing --with-asm=arm32 causes a failure in the check_NX security test.

    This PR diff fixes it.

    Thanks, that’s reassuring!


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 02:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me