Labeled Refactor/Smell
pull
util: Remove unused (u)int64_t formatting macros
#1625
real-or-random on October 25, 2024 refactor/smell
real-or-random on October 25, 2024 refactor/smell
issue
Handle invalid inputs consistently with respect to constant-time
#1621
jonasnick on October 21, 2024 refactor/smell meta/development
jonasnick on October 21, 2024 refactor/smell meta/development
pull
Examples: swap magic numbers for EXIT_ codes
#1618
Cheapshot003 on October 15, 2024 user-documentation refactor/smell
Cheapshot003 on October 15, 2024 user-documentation refactor/smell
issue
“implicit conversion loses integer precision” warnings
#1617
hebasto on October 15, 2024 refactor/smell
hebasto on October 15, 2024 refactor/smell
pull
examples: do not retry generating seckey randomness in musig
#1616
jonasnick on October 13, 2024 user-documentation refactor/smell
jonasnick on October 13, 2024 user-documentation refactor/smell
issue
use EXIT_ codes instead of magic numbers for exit(…) and main return values
#1609
theStack on September 27, 2024 user-documentation refactor/smell good first issue
theStack on September 27, 2024 user-documentation refactor/smell good first issue
pull
cmake: Delete
hebasto on September 16, 2024 build refactor/smell
-DNDEBUG
from all available config-specific flags
#1606
hebasto on September 16, 2024 build refactor/smell
pull
doc: fix typos in
theStack on September 9, 2024 user-documentation refactor/smell
secp256k1_ecdsa_{recoverable_,}signature
API description
#1604
theStack on September 9, 2024 user-documentation refactor/smell
pull
#1570 improve examples: remove key generation loop
#1599
Cheapshot003 on August 29, 2024 user-documentation refactor/smell
Cheapshot003 on August 29, 2024 user-documentation refactor/smell
pull
use variable-time group addition in
theStack on August 14, 2024 performance refactor/smell
_ec_pubkey_combine
#1587
theStack on August 14, 2024 performance refactor/smell
pull
fixes a few grammatical errors
#1585
justinvforvendetta on August 13, 2024 refactor/smell meta/development
justinvforvendetta on August 13, 2024 refactor/smell meta/development
pull
cmake, test: Add
hebasto on August 12, 2024 build refactor/smell
secp256k1_
prefix to test names
#1582
hebasto on August 12, 2024 build refactor/smell
issue
Examples should not retry on bad randomness keys in a loop
#1570
real-or-random on July 12, 2024 user-documentation refactor/smell good first issue
real-or-random on July 12, 2024 user-documentation refactor/smell good first issue
pull
tests: refactor: tidy up util functions (#1491)
#1533
theStack on May 27, 2024 assurance refactor/smell
theStack on May 27, 2024 assurance refactor/smell
pull
cmake: Fix cache issue when integrating by downstream project
#1529
hebasto on May 11, 2024 build refactor/smell
hebasto on May 11, 2024 build refactor/smell
pull
msan: notate more variable assignments from assembly code
#1512
theuni on March 27, 2024 assurance refactor/smell
theuni on March 27, 2024 assurance refactor/smell
issue
tests: Tidy the util functions
#1491
real-or-random on February 1, 2024 assurance refactor/smell
real-or-random on February 1, 2024 assurance refactor/smell
pull
tests: add missing fe comparison checks for inverse field test cases
#1489
theStack on February 1, 2024 assurance refactor/smell
theStack on February 1, 2024 assurance refactor/smell
pull
Be stricter with side effects in VERIFY
#1485
real-or-random on January 17, 2024 assurance refactor/smell meta/development
real-or-random on January 17, 2024 assurance refactor/smell meta/development
pull
tests: Drop redundant _scalar_check_overflow calls
#1484
real-or-random on January 17, 2024 assurance refactor/smell
real-or-random on January 17, 2024 assurance refactor/smell
pull
build: Clean up handling of module dependencies
#1482
real-or-random on January 16, 2024 build refactor/smell
real-or-random on January 16, 2024 build refactor/smell
pull
include: make docs more consistent
#1476
jonasnick on January 4, 2024 user-documentation refactor/smell
jonasnick on January 4, 2024 user-documentation refactor/smell
issue
fe_sqr tests could be improved
#1472
Coding-Enthusiast on December 24, 2023 assurance refactor/smell
Coding-Enthusiast on December 24, 2023 assurance refactor/smell
pull
Don’t #include standard library headers unconditionally
#1461
real-or-random on December 13, 2023 build needs-changelog refactor/smell
real-or-random on December 13, 2023 build needs-changelog refactor/smell
pull
doc: improve secp256k1_fe_set_b32_mod doc
#1455
Coding-Enthusiast on December 8, 2023 refactor/smell
Coding-Enthusiast on December 8, 2023 refactor/smell
issue
secp256k1_fe_set_b32_mod doesn’t actually reduce anything
#1453
Coding-Enthusiast on December 6, 2023 refactor/smell
Coding-Enthusiast on December 6, 2023 refactor/smell
issue
Prefix all macros with SECP256K1_
#1449
real-or-random on December 1, 2023 refactor/smell development
real-or-random on December 1, 2023 refactor/smell development
pull
Return temporaries to being unsigned in secp256k1_fe_sqr_inner
#1442
roconnor-blockstream on November 14, 2023 assurance refactor/smell
roconnor-blockstream on November 14, 2023 assurance refactor/smell
pull
asm: add .note.GNU-stack section for non-exec stack
#1441
fanquake on November 13, 2023 build refactor/smell
fanquake on November 13, 2023 build refactor/smell
pull
correct assertion for secp256k1_fe_mul_inner
#1438
roconnor-blockstream on November 6, 2023 assurance refactor/smell
roconnor-blockstream on November 6, 2023 assurance refactor/smell
pull
POC: Self-contained headers
#1423
hebasto on September 11, 2023 ci build refactor/smell development
hebasto on September 11, 2023 ci build refactor/smell development
pull
ctimetests: Use new SECP256K1_CHECKMEM macros also for ellswift
#1400
real-or-random on August 15, 2023 ci side-channel refactor/smell
real-or-random on August 15, 2023 ci side-channel refactor/smell
pull
tests: simplify
theStack on August 7, 2023 refactor/smell
random_fe_non_zero
(remove loop limit and unneeded normalize)
#1395
theStack on August 7, 2023 refactor/smell
pull
Implement new policy for VERIFY_CHECK and #ifdef VERIFY (issue #1381)
#1393
theStack on August 4, 2023 refactor/smell
theStack on August 4, 2023 refactor/smell
pull
tests: Replace counting_illegal_callbacks with CHECK_ILLEGAL_VOID
#1390
jonasnick on July 28, 2023 assurance refactor/smell
jonasnick on July 28, 2023 assurance refactor/smell
pull
build: enable ellswift module via SECP_CONFIG_DEFINES
#1384
jonasnick on July 26, 2023 build refactor/smell
jonasnick on July 26, 2023 build refactor/smell
issue
Policy for VERIFY_CHECK and #ifdef VERIFY
#1381
real-or-random on July 24, 2023 assurance refactor/smell
real-or-random on July 24, 2023 assurance refactor/smell
issue
Remove
w0xlt on July 17, 2023 documentation needs-changelog refactor/smell
SECP256K1_WARN_UNUSED_RESULT
from secp256k1_keypair_*
functions
#1379
w0xlt on July 17, 2023 documentation needs-changelog refactor/smell
pull
ellswift: fix probabilistic test failure when swapping sides
#1378
jonasnick on July 17, 2023 assurance refactor/smell
jonasnick on July 17, 2023 assurance refactor/smell
issue
group: ge(j) should have as invariant that the curve equation holds
#1376
real-or-random on July 11, 2023 assurance refactor/smell
real-or-random on July 11, 2023 assurance refactor/smell
pull
field: Use
real-or-random on June 29, 2023 refactor/smell
restrict
consistently in fe_sqrt
#1366
real-or-random on June 29, 2023 refactor/smell
pull
tests: introduce helper for non-zero
theStack on June 26, 2023 assurance refactor/smell
random_fe_test()
results
#1358
theStack on June 26, 2023 assurance refactor/smell
pull
tests: refactor: take use of
theStack on June 25, 2023 refactor/smell
secp256k1_ge_x_on_curve_var
#1357
theStack on June 25, 2023 refactor/smell
pull
scalar: refactor: use
theStack on June 10, 2023 refactor/smell
secp256k1_{read,write}_be32
helpers
#1339
theStack on June 10, 2023 refactor/smell
pull
refactor: take use of
theStack on May 29, 2023 refactor/smell
secp256k1_scalar_{zero,one}
constants
#1330
theStack on May 29, 2023 refactor/smell
pull
Signed-digit based ecmult_const algorithm
#1184
sipa on December 30, 2022 performance refactor/smell
sipa on December 30, 2022 performance refactor/smell
issue
Setting counting_illegal_callback may hide failing tests
#1167
jonasnick on December 1, 2022 assurance refactor/smell
jonasnick on December 1, 2022 assurance refactor/smell
issue
Don’t #include standard library headers unconditionally
#1095
real-or-random on March 28, 2022 refactor/smell
real-or-random on March 28, 2022 refactor/smell
pull
Removes
siv2r on January 4, 2022 refactor/smell
_fe_equal_var
, and unwanted _fe_normalize_weak
calls (in tests)
#1062
siv2r on January 4, 2022 refactor/smell
issue
Make fe magnitude implied statically
#1001
real-or-random on October 28, 2021 assurance refactor/smell
real-or-random on October 28, 2021 assurance refactor/smell