bench: add –help option to bench_internal #1445

1. 
   theStack commented at 5:08 pm on November 23, 2023: contributor

   While coming up with commands for running the benchmarks for issue #726 (comment), I noticed that in contrast to bench{_ecmult}, bench_internal doesn’t have a help option yet and figured it would be nice to have one. A comparable past PR is #1008. Benchmark categories appear in the same order as they are executed, the concrete benchmark names in parantheses per category are listed in alphabetical order.
2. in src/bench_internal.c:27 in e2cfea0c5d outdated

   22+    printf("    - Scalar operations (modulo the curve's order)\n");
   23+    printf("    - Field operations (modulo the curve's field size)\n");
   24+    printf("    - Group operations (both in Jacobian and affine coordinates)\n");
   25+    printf("    - Point multiplication\n");
   26+    printf("    - Hash algorithms\n");
   27+    printf("    - Context object handling\n");
   

   ---

   ---

   

   real-or-random commented at 10:02 pm on November 23, 2023:

   Perhaps it suffices to say “Benchmarks various internal routines”. This list is mostly redundant to the list below. If we omit it, we won’t need to (remember to) touch two lists every time we add or remove operations.

   ---

   

   theStack commented at 1:35 am on November 24, 2023:

   Agree, done.
3. 
   real-or-random commented at 10:02 pm on November 23, 2023: contributor

   Concept ACK
4. real-or-random added the label refactor/smell on Nov 23, 2023
5. bench: add --help option to bench_internal 1ddd76af0a
6. theStack force-pushed on Nov 24, 2023
7. real-or-random approved
8. 
   real-or-random commented at 7:53 am on November 24, 2023: contributor

   utACK 1ddd76af0a735b7fcbec7f37c0d99a7db9893ac1
9. 
   siv2r commented at 1:11 pm on November 24, 2023: contributor

   ACK 1ddd76a, tested the --help option locally, and it works as expected.
10. real-or-random merged this on Nov 24, 2023
11. real-or-random closed this on Nov 24, 2023

    ---

12. theStack deleted the branch on Nov 24, 2023

Contributors
theStack real-or-random siv2r

Labels
refactor/smell