secp256k1_fe_sqrt checks for success #15

1. 
   peterdettman commented at 5:44 am on May 19, 2014: contributor

   • secp256k1_fe_sqrt now checks that the value it calculated is actually a square root.
   • Add return values to secp256k1_fe_sqrt and secp256k1_ge_set_xo.
   • Callers of secp256k1_ge_set_xo can use return value instead of explicit validity checks
   • Add random value tests for secp256k1_fe_sqrt
2. secp256k1_fe_sqrt checks for success

   - secp256k1_fe_sqrt now checks that the value it calculated is actually a square root.
   - Add return values to secp256k1_fe_sqrt and secp256k1_ge_set_xo.
   - Callers of secp256k1_ge_set_xo can use return value instead of explicit validity checks
   - Add random value tests for secp256k1_fe_sqrt

   d397954723
3. Merge branch 'master' of https://github.com/bitcoin/secp256k1 into peterdettman-checked-sqrt 535271b1fb
4. Check against known-answer in test-sqrt db8a9c5589
5. 
   sipa commented at 6:07 pm on May 19, 2014: contributor

   Very nice - thanks especially for increasing the test coverage!

   One nit: can you squash the commits?

6. 
   peterdettman commented at 1:00 pm on May 20, 2014: contributor

   @sipa Can do; I’ll try to get to it tomorrow.
7. 
   peterdettman commented at 3:53 am on May 21, 2014: contributor

   Closed in favour of a new pull request with the commits squashed.
8. peterdettman closed this on May 21, 2014

   ---

9. 
   laanwj commented at 9:08 am on May 21, 2014: member

   @peterdettman you don’t need to open a new pull when you squash the commits, you can just squash then force-push to the same branch and it will appear in the current one.
10. 
    peterdettman commented at 10:01 am on May 21, 2014: contributor

    @laanwj ok, I’ll remember for next time.
11. peterdettman deleted the branch on May 22, 2014

Contributors
peterdettman sipa laanwj