[API BREAK] Explicit flag handling (rebase + modification of #324) #339

pull sipa wants to merge 2 commits into bitcoin-core:master from sipa:flag-safety changing 6 files +44 −28
  1. sipa commented at 3:44 pm on October 21, 2015: contributor
  2. sipa force-pushed on Oct 21, 2015
  3. sipa commented at 3:48 pm on October 21, 2015: contributor

    This is an update of #324 with the following changes:

    • Keep the lower 8 bits of flags to indicate their type
    • Revert the change to pass-through the compression flag to the eckey module (which was a layer violation, the flag was defined at a higher level but used on a lower one).
  4. sipa commented at 3:49 pm on October 21, 2015: contributor
    Comments, @rustyrussell @luke-jr ?
  5. sipa force-pushed on Oct 21, 2015
  6. sipa renamed this:
    Explicit flag handling (rebase + modification of #324)
    [API BREAK] Explicit flag handling (rebase + modification of #324)
    on Oct 21, 2015
  7. luke-jr commented at 5:24 am on October 22, 2015: member

    I do not understand the reason for pulling flags out of src/eckey_impl.h.

    Besides that, fully-reviewed-and-seems-good ACK.

  8. sipa commented at 11:24 am on October 22, 2015: contributor
    Luke: the lower-level eckey code should not depend on the top-level wrapper whose interface is exposed.
  9. sipa force-pushed on Oct 22, 2015
  10. sipa commented at 10:37 pm on October 22, 2015: contributor
    Rebased, and renamed unsigned int to int for bool flag.
  11. Make flags more explicit, add runtime checks.
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    1a368980c8
  12. Overhaul flags handling 9234391ed4
  13. sipa force-pushed on Oct 24, 2015
  14. sipa commented at 5:49 pm on October 24, 2015: contributor
    Rebased on top of #340.
  15. sipa merged this on Oct 25, 2015
  16. sipa closed this on Oct 25, 2015

  17. sipa referenced this in commit 73f64ff8f3 on Oct 25, 2015
  18. sipa cross-referenced this on Oct 25, 2015 from issue [API BREAK] Make flags more explicit, add runtime checks. by rustyrussell


sipa luke-jr


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 13:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me