field: Use restrict consistently in fe_sqrt #1366

1. 
   real-or-random commented at 2:48 pm on June 29, 2023: contributor

   That is, use it also in the definition and not only the declaration.

   I believe this was the intention of commit https://github.com/bitcoin-core/secp256k1/commit/be82bd8e0347e090037ff1d30a22a9d614db8c9f, but it was omitted there.

   edit: Changed the description. I’m not entirely sure but after looking at the standard, I tend to think this is more than a cosmetic change, and only this change actually makes the parameters restrict. Anyway, I believe making them restrict was simply forgotten in be82bd8e0347e090037ff1d30a22a9d614db8c9f.

2. real-or-random added the label documentation on Jun 29, 2023
3. field: Use `restrict` consistently in fe_sqrt

   That is, use it also in the definition and not only the declaration.
   
   I believe this was the intention of commit
   be82bd8e0347e090037ff1d30a22a9d614db8c9f, but it was omitted there.

   b79ba8aa4c
4. real-or-random force-pushed on Jul 6, 2023
5. real-or-random removed the label documentation on Jul 6, 2023
6. real-or-random added the label documentation on Jul 6, 2023
7. real-or-random added the label refactor/smell on Jul 6, 2023
8. real-or-random removed the label documentation on Jul 6, 2023
9. 
   sipa commented at 0:08 am on July 9, 2023: contributor

   utACK b79ba8aa4c074b2cd09188f6f85ba68d6b80fe50
10. real-or-random merged this on Jul 11, 2023
11. real-or-random closed this on Jul 11, 2023

    ---

12. 
    real-or-random commented at 11:15 pm on July 11, 2023: contributor

    I double-checked all the call sites manually, and we check aliasing in VERIFY mode, so I think it’s safe to merge this.
13. fanquake referenced this in commit 56c05c5ec4 on Jul 17, 2023
14. fanquake referenced this in commit ff061fde18 on Jul 18, 2023
15. hebasto referenced this in commit 270d2b37b8 on Jul 21, 2023
16. jonasnick cross-referenced this on Jul 27, 2023 from issue Upstream PRs 1357, 1345, 1358, 1368, 1369, 1323, 1364, 1370, 1367, 1344, 1371, 1363, 1340, 1366, 1313, 1378, 1298, 1382, 1383, 1384, 1386 by jonasnick

Contributors
real-or-random sipa

Labels
refactor/smell