cmake: Make secp256k1_objs inherit interface defines from secp256k1 #1704

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:250718-win-static changing 1 files +2 −1
  1. hebasto commented at 4:39 pm on July 18, 2025: member

    This PR effectively adds -DSECP256K1_STATIC to usage requirements of secp256k1_objs on Windows, preventing LNK4217 linker warnings.

    I overlooked this issue while reviewing #1678.

  2. cmake: Make `secp256k1_objs` inherit interface defines from `secp256k1`
    This change effectively adds `-DSECP256K1_STATIC` to usage requirements
    of `secp256k1_objs` on Windows, preventing LNK4217 linker warnings.
    bf082221ff
  3. hebasto commented at 4:41 pm on July 18, 2025: member

    I overlooked this issue while reviewing #1678.

    It would be nice to have this included in 0.7.0, along with #1678.

  4. hebasto commented at 4:41 pm on July 18, 2025: member
    cc @theuni
  5. real-or-random added the label build on Jul 18, 2025
  6. real-or-random added the label refactor/smell on Jul 18, 2025
  7. real-or-random added this to the milestone 0.7.0 on Jul 18, 2025
  8. real-or-random approved
  9. real-or-random commented at 11:36 am on July 21, 2025: contributor
    utACK bf082221ff55be706e162f1a15e9df3247ef7e7b
  10. real-or-random merged this on Jul 21, 2025
  11. real-or-random closed this on Jul 21, 2025


hebasto real-or-random

Labels
build refactor/smell

Milestone
0.7.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-31 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me