ecdsa: VERIFY_CHECK result of _fe_set_b32_limit #1839

1. 
   real-or-random commented at 4:00 pm on March 23, 2026: contributor

   This also avoids a spurious -Wmaybe-uninitialized warning emitted by gcc 16 (snapshot) when compiling with -DDETERMINISTIC.

   Alternative to #1838 by @mllwchrry who tried very a similar thing as this PR but couldn’t convince the compiler. (The GCC snapshot is very annoying: a simple VERIFY_CHECK(secp256k1_fe_set_b32_limit(&xr, c)) doesn’t do the trick. I found this variant here with a local store rather by accident.)

2. ecdsa: VERIFY_CHECK result of _fe_set_b32_limit

   This also avoids a spurious "-Wmaybe-uninitialized" warning emitted by
   gcc 16 (snapshot) when compiling with -DDETERMINISTIC.

   43fca0ff55
3. real-or-random added the label tweak/refactor on Mar 23, 2026
4. 
   mllwchrry commented at 2:51 pm on March 24, 2026: contributor

   Good solution. I find it more robust since it verifies the range assumption rather than just zero-initializing. I’ll close my PR.
5. 
   mllwchrry commented at 10:40 am on March 25, 2026: contributor

   ACK 43fca0f I tested the fix with the extended CI coverage and everything succeeded.
6. theStack approved
7. 
   theStack commented at 2:57 pm on March 25, 2026: contributor

   utACK 43fca0ff5594c1f25ef0ce63556b2ed344282190
8. real-or-random merged this on Mar 25, 2026
9. real-or-random closed this on Mar 25, 2026

   ---

Contributors
real-or-random mllwchrry theStack

Labels
tweak/refactor