ci: Simplify module configuration and extend test coverage #1840

1. 
   mllwchrry commented at 5:46 pm on March 25, 2026: contributor

   Enables all modules by default, and tests the disabling of each module separately (respecting the dependency chain). This simplifies the configuration of modules in CI and extends the test coverage.

   The extended coverage is proven by exposing pre-existing issues fixed in #1837 and #1839.

2. ci: Simplify module configuration 3bc392ef54
3. real-or-random added the label assurance on Mar 25, 2026
4. real-or-random added the label ci on Mar 25, 2026
5. real-or-random added the label tweak/refactor on Mar 25, 2026
6. 
   real-or-random commented at 8:52 pm on March 25, 2026: contributor

   Concept ACK

   This simplifies the CI file and it gives us more test coverage.

   cc @hebasto

   I kicked CI. The failed runs all had some network/GHA issues.

7. real-or-random requested review from Copilot on Mar 25, 2026
8. in .github/workflows/ci.yml:111 in 3bc392ef54

   115+          - env_vars: { CFLAGS: '-O1' }
   116           - env_vars: { ECMULTGENKB: 2, ECMULTWINDOW: 2 }
   117           - env_vars: { ECMULTGENKB: 86, ECMULTWINDOW: 4 }
   118+          - env_vars: { ECDH: 'no' }
   119+          - env_vars: { RECOVERY: 'no' }
   120+          - env_vars: { EXTRAKEYS: 'no', SCHNORRSIG: 'no', MUSIG: 'no' }
   

   ---

   ---

   

   Copilot commented at 9:00 pm on March 25, 2026:

   The EXTRAKEYS: 'no' configuration should also disable ELLSWIFT. In secp256k1, the ellswift module depends on extrakeys; with global defaults now setting ELLSWIFT: 'yes', line 111 will still leave ellswift enabled and can fail configuration (or at least not reflect the intended dependency-respecting disable-case). Update that matrix entry to include ELLSWIFT: 'no' alongside EXTRAKEYS: 'no'.

   0          - env_vars: { EXTRAKEYS: 'no', ELLSWIFT: 'no', SCHNORRSIG: 'no', MUSIG: 'no' }
   

   ---

   

   real-or-random commented at 9:21 pm on March 25, 2026:

   This is simply wrong.
9. 
   Copilot commented at 9:01 pm on March 25, 2026: none

   Pull request overview

   Updates CI defaults to enable secp256k1 modules by default and expands the matrix to validate each module can be disabled independently while respecting dependencies.

   Changes:

   • Switch module env defaults (ECDH/RECOVERY/EXTRAKEYS/SCHNORRSIG/MUSIG/ELLSWIFT) from disabled to enabled.
   • Simplify existing CI matrix entries by removing repetitive per-job module enabling.
   • Add new matrix entries that explicitly disable each module (or dependent groups) to increase coverage.

   ---

   💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Contributors
mllwchrry real-or-random Copilot

Labels
assurance ci tweak/refactor