Run a Travis test on s390x (big endian) #696

1. 
   sipa commented at 7:27 pm on November 28, 2019: contributor
2. 
   sipa commented at 7:33 pm on November 28, 2019: contributor

   checking whether byte ordering is bigendian… yes

   \o/

3. 
   elichai commented at 7:35 pm on November 28, 2019: contributor

   It worked on core :P But still satisfying to see. There’s nothing more satisfying than seeing that your code works on an edge case you never tested before lol
4. 
   jonasnick commented at 7:54 am on November 29, 2019: contributor

   Cool! What’s missing for un-WIP’ing? How about turning on the ECDH and recovery module?
5. real-or-random cross-referenced this on Jan 6, 2020 from issue General CI discussion by real-or-random
6. real-or-random cross-referenced this on Jul 21, 2020 from issue Get rid of autoconf check for endianness by real-or-random
7. 
   real-or-random commented at 12:14 pm on July 21, 2020: contributor

   Cool! What’s missing for un-WIP’ing? How about turning on the ECDH and recovery module? @sipa Could you do this, and maybe also add a comment to the Travis file that this is a big-endian host?

8. elichai cross-referenced this on Jul 28, 2020 from issue Travis should build and test arm asm by gmaxwell
9. in .travis.yml:39 in 4f682a4e40 outdated

   34@@ -35,6 +35,9 @@ env:
   35 matrix:
   36   fast_finish: true
   37   include:
   38+    - compiler: gcc
   39+      env: HOST=s390x-unknown-linux-gnu DOCKER_NAME_TAG=s390x/ubuntu:18.04
   

   ---

   ---

   

   MarcoFalke commented at 8:16 am on July 28, 2020:

   What does DOCKER_NAME_TAG do?

   0      env: HOST=s390x-unknown-linux-gnu
   

   ---

   

   sipa commented at 0:36 am on July 29, 2020:

   I have no idea anymore, I assume I copied it from somewhere.
10. sipa force-pushed on Jul 29, 2020
11. sipa renamed this:
    [WIP] Let's see if s390x testing works
    Run a Travis test on s390x (big endian)
    on Jul 29, 2020
12. sipa force-pushed on Jul 29, 2020
13. 
    sipa commented at 1:50 am on July 29, 2020: contributor

    Rebased, and added ECDH/recovery.

    I did notice valgrind ctime test failure on this line in src/scalar_4x64_impl.h:

    0    no |= (a->d[1] < SECP256K1_N_1);
    

    so I’ve disabled the ctime test for now.

14. in .travis.yml:88 in a940a7127e outdated

    82@@ -83,6 +83,10 @@ matrix:
    83             - valgrind
    84             - libtool-bin
    85             - libc6-dbg:i386
    86+    # S390x build (big endian system)
    87+    - compiler: gcc
    88+      env: HOST=s390x-unknown-linux-gnu ECDH=yes RECOVERY=yes EXPERIMENTAL=yes CTIMETEST=no
    

    ---

    ---

    

    real-or-random commented at 5:50 am on July 29, 2020:

    travis still doesn’t like you

    0      env: HOST=s390x-unknown-linux-gnu ECDH=yes RECOVERY=yes EXPERIMENTAL=yes CTIMETEST=
    

    I admit that this is not intuitive…

15. 
    real-or-random commented at 5:51 am on July 29, 2020: contributor

    0    no |= (a->d[1] < SECP256K1_N_1);
    

    and two lines below too:

    https://github.com/bitcoin-core/secp256k1/blob/master/src/scalar_4x64_impl.h#L65

    so I’ve disabled the ctime test for now.

    makes sense.

16. real-or-random changes_requested
17. 
    real-or-random commented at 6:07 am on July 30, 2020: contributor

    ACK c5e43bb8d6c60c5f8ee38c89ac4d0d755e6515d0 Travis works and says it’s big endian

    The travis failure is a randomness test again (#68), see https://travis-ci.org/github/bitcoin-core/secp256k1/jobs/713125311#L497

    If you want, you can squash this. Otherwise I’ll just merge it in the next days if noone objects.

18. elichai cross-referenced this on Jul 30, 2020 from issue Check if variable=yes instead of if var is set in travis.sh by elichai
19. Test travis s390x (big endian) 39295362cf
20. real-or-random force-pushed on Aug 7, 2020
21. real-or-random approved
22. 
    real-or-random commented at 10:49 am on August 7, 2020: contributor

    ACK 39295362cfc856aae1c37cc1194c2f6d53fd6f25 Travis works and says it’s big endian

    (I squashed this for merging).

23. real-or-random merged this on Aug 7, 2020
24. real-or-random closed this on Aug 7, 2020

    ---

25. real-or-random cross-referenced this on Aug 8, 2020 from issue Use preprocessor macros instead of autoconf to detect endianness by real-or-random
26. jasonbcox referenced this in commit f7cc6a9fb9 on Sep 29, 2020
27. deadalnix referenced this in commit a894289a5a on Sep 30, 2020

Contributors
sipa elichai jonasnick real-or-random MarcoFalke