Fix shutdown hang with >= 8 -addnodes set (0.14 backport) #10013

1. 
   TheBlueMatt commented at 4:53 PM on March 16, 2017: member

   See #9953.

2. gmaxwell approved
3. 
   gmaxwell commented at 5:07 PM on March 16, 2017: contributor

   utACK (will test)

4. fanquake added the label Backport on Mar 17, 2017
5. fanquake added the label P2P on Mar 17, 2017
6. fanquake added this to the milestone 0.14.1 on Mar 17, 2017
7. Fix shutdown hang with >= 8 -addnodes set

   We previously would block waiting for a CSemaphoreGrant in
   ThreadOpenAddedConnections, when we did not need to. This would
   block as the posts in CConnman shutdown were both to the wrong
   semaphore and in the wrong location.
   
   Github-Pull: #9953
   Rebased-From: e007b243c4840e44857b5ccf686ed35899e44af0

   d2548a4f97
8. Add missing braces in semaphore posts in net

   Github-Pull: #9953
   Rebased-From: 819b513a5415d1669b5440e214862cda6c2261f8

   4e2502bb51
9. TheBlueMatt force-pushed on Mar 17, 2017
10. 
    TheBlueMatt commented at 9:57 PM on March 17, 2017: member

    Added Github-Pull and Rebased-From metadata to commit messages.

11. laanwj merged this on Mar 18, 2017
12. laanwj closed this on Mar 18, 2017

    ---

13. laanwj referenced this in commit fa8c6ddbef on Mar 18, 2017
14. DrahtBot locked this on Sep 8, 2021

Milestone
0.14.1