Fix shutdown hang with >= 8 -addnodes set #9953

1. 
   TheBlueMatt commented at 4:26 PM on March 8, 2017: member

   We previously would block waiting for a CSemaphoreGrant, when we did not need to.

2. TheBlueMatt force-pushed on Mar 8, 2017
3. 
   laanwj commented at 4:38 PM on March 8, 2017: member

   utACK https://github.com/bitcoin/bitcoin/pull/9953/commits/569b6eec8a640581f78432688567f04e2a4f3056 (fix changed since I last reviewed)

4. laanwj added the label Needs backport on Mar 8, 2017
5. laanwj added the label P2P on Mar 8, 2017
6. laanwj added this to the milestone 0.14.1 on Mar 8, 2017
7. Fix shutdown hang with >= 8 -addnodes set

   We previously would block waiting for a CSemaphoreGrant in
   ThreadOpenAddedConnections, when we did not need to. This would
   block as the posts in CConnman shutdown were both to the wrong
   semaphore and in the wrong location.

   e007b243c4
8. TheBlueMatt force-pushed on Mar 8, 2017
9. 
   TheBlueMatt commented at 7:44 PM on March 8, 2017: member

   Changed the fix to post to semAddnode instead of TryAcquire.

10. Add missing braces in semaphore posts in net 819b513a54
11. gmaxwell approved
12. 
    gmaxwell commented at 8:11 PM on March 8, 2017: contributor

    utACK. (will test) Thanks.

13. 
    theuni commented at 1:30 AM on March 9, 2017: member

    utACK 819b513a5415d1669b5440e214862cda6c2261f8

14. 
    jonasschnelli commented at 7:56 AM on March 9, 2017: contributor

    utACK 819b513a5415d1669b5440e214862cda6c2261f8

15. 
    jonasschnelli commented at 10:06 AM on March 10, 2017: contributor

    Should fix: #9950

16. gmaxwell approved
17. 
    gmaxwell commented at 7:51 PM on March 12, 2017: contributor

    ACK.

18. laanwj merged this on Mar 13, 2017
19. laanwj closed this on Mar 13, 2017

    ---

20. laanwj referenced this in commit f8a709161f on Mar 13, 2017
21. TheBlueMatt referenced this in commit d2548a4f97 on Mar 17, 2017
22. TheBlueMatt referenced this in commit 4e2502bb51 on Mar 17, 2017
23. MarcoFalke removed the label Needs backport on Mar 27, 2017
24. codablock referenced this in commit 4321788cc9 on Jan 26, 2018
25. lateminer referenced this in commit 6a311073e0 on Jan 5, 2019
26. lateminer referenced this in commit 560bc72a6d on Jan 5, 2019
27. andvgal referenced this in commit b209acc89f on Jan 6, 2019
28. CryptoCentric referenced this in commit 86c678fa97 on Feb 27, 2019
29. DrahtBot locked this on Sep 8, 2021

Milestone
0.14.1