Previously if we didn't have any local addresses, GetLocalAddress would return 0.0.0.0 and then we'd swap in a peer's notion of our address in AdvertiseLocal, but then nServices would never get set.
This would prevent a node behind a NAT from having its nServices set in addr messages gossiped between peers and could lead to no incoming connections.
This should be backported to 0.14 (and 0.13 if we do that)
I can't promise that I've fully understood all the implications here.
Previously if we didn't have any local addresses, GetLocalAddress would return
0.0.0.0 and then we'd swap in a peer's notion of our address in AdvertiseLocal,
but then nServices would never get set.
utACK.
Restarted the failing test.
utACK 307013469f9a3b8f13d3eb9dbeea419a55148493. Failing test was unrelated. I'm working on a fix for it, though.
utACK 307013469f9a3b8f13d3eb9dbeea419a55148493
utACK 307013469f9a3b8f13d3eb9dbeea419a55148493
Postumous utACK