Clarify CCoinsViewMemPool documentation. #10685

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2017-06-ccoinsviewmempool-doc-cleanup changing 2 files +8 −1

TheBlueMatt commented at 6:46 PM on June 27, 2017: member

Thanks to @sdaftuar for correcting my misunderstanding.

Clarify CCoinsViewMemPool documentation.

Thanks to @sdaftuar for correcting my misunderstanding.

381b8fc365

TheBlueMatt force-pushed on Jun 27, 2017
sipa commented at 6:51 PM on June 27, 2017: member

ACK
morcos commented at 7:01 PM on June 27, 2017: member

ACK
gmaxwell approved
gmaxwell commented at 7:11 PM on June 27, 2017: contributor

ACK
sdaftuar commented at 7:49 PM on June 27, 2017: member

ACK
fanquake added the label Docs and Output on Jun 28, 2017
fanquake added the label Mempool on Jun 28, 2017
fanquake commented at 12:39 AM on June 28, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/10685/commits/381b8fc36537f9fa42f4487bcf55920b2ae0bda9

in src/rpc/blockchain.cpp:994 in 381b8fc365

 990 | @@ -991,7 +991,7 @@ UniValue gettxout(const JSONRPCRequest& request)
 991 |      if (fMempool) {
 992 |          LOCK(mempool.cs);
 993 |          CCoinsViewMemPool view(pcoinsTip, mempool);
 994 | -        if (!view.GetCoin(out, coin) || mempool.isSpent(out)) { // TODO: filtering spent coins should be done by the CCoinsViewMemPool
 995 | +        if (!view.GetCoin(out, coin) || mempool.isSpent(out)) {

dougstrong77 commented at 1:13 PM on June 28, 2017:

Fuck

sipa merged this on Jun 28, 2017
sipa closed this on Jun 28, 2017
sipa referenced this in commit 30c21306c1 on Jun 28, 2017
PastaPastaPasta referenced this in commit d79686322b on Jul 6, 2019
PastaPastaPasta referenced this in commit e998e239e1 on Jul 8, 2019
PastaPastaPasta referenced this in commit c0c7a15d4c on Jul 9, 2019
PastaPastaPasta referenced this in commit 48376561dc on Jul 11, 2019
PastaPastaPasta referenced this in commit df13c03ebf on Jul 13, 2019
PastaPastaPasta referenced this in commit 0a215695a8 on Jul 17, 2019
barrystyle referenced this in commit bfbbbdf761 on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels