[test] don't run dbcrash.py on Travis #10743

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:dontrundbcrash changing 1 files +1 −1
  1. jnewbery commented at 4:33 PM on July 4, 2017: member

    dbcrash.db is disk intensive (it's stop-starting nodes and flushing to disk many times). Travis performs badly with heavy disk load and even with the fixes in #10704 the test still fails with timeouts in individual calls.

    Even if none of the individual calls timeout, the test takes far too long on Travis. Here's an example of the test timing out the 20 minute max for an individual functional test: https://travis-ci.org/bitcoin/bitcoin/jobs/250016845. Note that the test was only about half way through when it was killed, so without the timeout in test_runner this would have taken ~40 minutes and travis would have killed the job.

    For now I think we should just exclude dbcrash.py from Travis in the same way as pruning.py. It doesn't make sense to run disk-heavy tests on Travis.

  2. [test] don't run dbcrash.py on Travis bd00fa52a1
  3. fanquake added the label Tests on Jul 5, 2017
  4. fanquake commented at 4:13 AM on July 5, 2017: member

    utACK bd00fa5

  5. practicalswift commented at 8:22 AM on July 5, 2017: contributor

    utACK bd00fa52a1818f125c32d9759c3ddf506310271a

  6. gmaxwell commented at 8:49 AM on July 5, 2017: contributor

    :-/ No disagreement, but we need a way to run these tests.

  7. jnewbery commented at 9:19 AM on July 5, 2017: member

    we need a way to run these tests.

    for now, it's locally or not at all. Note that this is an extended test that was being run in the travis daily cron job. We weren't even running the extended tests on Travis at all until a couple of months ago, so we're in a lot better place than we were then.

  8. laanwj commented at 1:54 PM on July 6, 2017: member

    :-/ No disagreement, but we need a way to run these tests.

    The way to run these tests, as well as all others, is simply:

    test/functional/test_runner.py --extended
    

    Running tests on Travis is not meant as replacement for running them locally.

  9. laanwj merged this on Jul 6, 2017
  10. laanwj closed this on Jul 6, 2017

  11. laanwj referenced this in commit be82498462 on Jul 6, 2017
  12. jnewbery deleted the branch on Jul 6, 2017
  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me