Declare single-argument (non-converting) constructors "explicit" #10969

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:explicit changing 68 files +105 −105

practicalswift commented at 12:04 PM on August 1, 2017: contributor

Declare single-argument (non-converting) constructors explicit.

In order to avoid unintended implicit conversions.

For a more thorough discussion, see "C.46: By default, declare single-argument constructors explicit" in the C++ Core Guidelines (Stroustrup & Sutter).
jonasschnelli added the label Refactoring on Aug 3, 2017
practicalswift force-pushed on Aug 9, 2017
practicalswift force-pushed on Aug 11, 2017
practicalswift commented at 1:35 PM on August 11, 2017: contributor

Rebased! Feel free to review :-)
fanquake commented at 1:34 PM on August 12, 2017: member

Rebooted the failing test.
practicalswift commented at 2:38 PM on August 12, 2017: contributor

Thanks!
MarcoFalke commented at 12:46 AM on August 16, 2017: member

utACK 3bdbbce
Declare single-argument (non-converting) constructors "explicit"
In order to avoid unintended implicit conversions.
64fb0ac016
practicalswift force-pushed on Aug 16, 2017
practicalswift commented at 2:33 PM on August 16, 2017: contributor

Rebased!
laanwj commented at 8:58 PM on August 17, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/10969/commits/64fb0ac016c7fd01c60c39af60f6431bac57f9ee, this is a good precaution to avoid accidental "automatic conversions".
laanwj merged this on Aug 18, 2017
laanwj closed this on Aug 18, 2017
laanwj referenced this in commit 4afb5aa9e1 on Aug 18, 2017
MarcoFalke referenced this in commit 3f726c99f8 on Aug 25, 2017
sickpig referenced this in commit e64ef7fbc4 on Jan 11, 2018
sickpig referenced this in commit db75b3d3ce on Jan 11, 2018
PastaPastaPasta referenced this in commit ea99051b54 on Sep 19, 2019
PastaPastaPasta referenced this in commit b42580ebac on Sep 19, 2019
PastaPastaPasta referenced this in commit 80ec4c82c6 on Sep 23, 2019
PastaPastaPasta referenced this in commit 88877df475 on Sep 23, 2019
PastaPastaPasta referenced this in commit 7b634b2d57 on Sep 24, 2019
PastaPastaPasta referenced this in commit e0f44f788a on Sep 24, 2019
PastaPastaPasta referenced this in commit ef6aa695c8 on Nov 19, 2019
PastaPastaPasta referenced this in commit 4bdaa1443d on Nov 21, 2019
PastaPastaPasta referenced this in commit afacabb3ed on Dec 9, 2019
PastaPastaPasta referenced this in commit df95840315 on Dec 22, 2019
PastaPastaPasta referenced this in commit 763b9b25f0 on Jan 1, 2020
PastaPastaPasta referenced this in commit a40f5393a2 on Jan 2, 2020
PastaPastaPasta referenced this in commit d33ee8b1cd on Jan 2, 2020
PastaPastaPasta referenced this in commit 68f612f958 on Jan 2, 2020
PastaPastaPasta referenced this in commit f75b7ef8ab on Jan 4, 2020
PastaPastaPasta referenced this in commit 7f24409d22 on Jan 4, 2020
PastaPastaPasta referenced this in commit 284268dd6f on Jan 10, 2020
PastaPastaPasta referenced this in commit 9249670002 on Jan 10, 2020
PastaPastaPasta referenced this in commit fdf3f25a0a on Jan 10, 2020
PastaPastaPasta referenced this in commit 87d90136c9 on Jan 12, 2020
str4d referenced this in commit e591f94fcf on Jul 31, 2020
zkbot referenced this in commit 5ef5d8d268 on Jul 31, 2020
zkbot referenced this in commit 7d94064616 on Sep 29, 2020
ckti referenced this in commit 3a486ab694 on Mar 28, 2021
ckti referenced this in commit d23b02369c on Mar 28, 2021
gades referenced this in commit 6d8571b958 on Jun 25, 2021
gades referenced this in commit ecb5193a3f on Jun 30, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11112 [developer-notes] By default, declare single-argument constructors "explicit"