[developer-notes] By default, declare single-argument constructors "explicit" #11112

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:declare-single-argument-constructors-explicit changing 2 files +7 −1
  1. practicalswift commented at 8:57 PM on August 22, 2017: contributor

    This is a follow-up to the now merged #10969.

    Add recommendation:

    By default, declare single-argument constructors explicit.

    • Rationale: This is a precaution to avoid unintended conversions that might arise when single-argument constructors are used as implicit conversion functions.
  2. Add recommendation: By default, declare single-argument constructors `explicit` f1708ef89a
  3. practicalswift renamed this:
    developer-notes: By default, declare single-argument constructors `explicit`.
    developer-notes: By default, declare single-argument constructors `explicit`
    on Aug 22, 2017
  4. practicalswift renamed this:
    developer-notes: By default, declare single-argument constructors `explicit`
    developer-notes: By default, declare single-argument constructors "explicit"
    on Aug 22, 2017
  5. laanwj added the label Docs and Output on Aug 23, 2017
  6. laanwj commented at 10:06 AM on August 23, 2017: member

    ACK f1708ef89a38efe857daeb4252c6dfab5b7c258e

  7. MarcoFalke commented at 1:06 PM on August 23, 2017: member

    ACK f1708ef

  8. sipa commented at 4:16 PM on August 23, 2017: member

    ACK

  9. practicalswift renamed this:
    developer-notes: By default, declare single-argument constructors "explicit"
    [developer-notes] By default, declare single-argument constructors "explicit"
    on Aug 23, 2017
  10. fanquake commented at 1:38 AM on August 24, 2017: member

    ACK f1708ef

  11. MarcoFalke merged this on Aug 25, 2017
  12. MarcoFalke closed this on Aug 25, 2017
  13. MarcoFalke referenced this in commit 3f726c99f8 on Aug 25, 2017
  14. MarcoFalke cross-referenced this on Oct 20, 2018 from issue test: Add linter to make sure single parameter constructors are marked explicit by practicalswift
  15. PastaPastaPasta referenced this in commit b42580ebac on Sep 19, 2019
  16. PastaPastaPasta referenced this in commit 88877df475 on Sep 23, 2019
  17. PastaPastaPasta referenced this in commit e0f44f788a on Sep 24, 2019
  18. PastaPastaPasta referenced this in commit ef6aa695c8 on Nov 19, 2019
  19. PastaPastaPasta referenced this in commit 4bdaa1443d on Nov 21, 2019
  20. PastaPastaPasta referenced this in commit afacabb3ed on Dec 9, 2019
  21. PastaPastaPasta referenced this in commit 763b9b25f0 on Jan 1, 2020
  22. PastaPastaPasta referenced this in commit a40f5393a2 on Jan 2, 2020
  23. PastaPastaPasta referenced this in commit d33ee8b1cd on Jan 2, 2020
  24. promag cross-referenced this on May 3, 2020 from issue Span improvements by sipa
  25. ckti referenced this in commit 3a486ab694 on Mar 28, 2021
  26. practicalswift deleted the branch on Apr 10, 2021
  27. gades referenced this in commit 0cd4410bac on Apr 21, 2022
  28. bitcoin locked this on Aug 18, 2022
Contributors
practicalswiftlaanwjMarcoFalkesipafanquake
Labels
Docs
Linked (view graph)
#10969 Declare single-argument (non-converting) constructors "explicit"#14505 test: Add linter to make sure single parameter constructors are marked explicit#18468 Span improvements
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 08:55 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me