[0.15] Final to-do's for 0.15.0 release notes #11280

meshcollider commented at 11:01 PM on September 7, 2017: contributor

Closes #11174

I may have missed things that should be included, happy to amend :)

laanwj added the label Docs and Output on Sep 7, 2017

laanwj commented at 11:26 PM on September 7, 2017: member

Concept ACK (never mind the travis fail, I cancelled travis here to save resources)

in doc/release-notes.md:70 in 883be25933 outdated

  65 | +wallet support, is coming in a next version.
  66 | +
  67 | +Rescanning with encrypted wallets
  68 | +---------------------------------
  69 | +
  70 | +When using an encrypted HD wallet, the keypool cannot be topped up without unlocking the wallet. This means that

instagibbs commented at 11:37 PM on September 7, 2017:

might want to note this is not a regression, right?

in doc/release-notes.md:64 in 883be25933 outdated

  59 | +Current SegWit Support
  60 | +----------------------
  61 | +
  62 | +Version 0.15.0 supports adding a segregated witness address via the `addwitnessaddress` RPC, but
  63 | +please note that this is a testing/expert RPC, which does not guarantee recovery from backup. Only use
  64 | +this RPC if you know what you are doing. More complete support for segregated witness, including

sipa commented at 11:39 PM on September 7, 2017:

"including wallet support" sounds like there are other things missing. It's the only thing...

in doc/release-notes.md:72 in 883be25933 outdated

  67 | +Rescanning with encrypted wallets
  68 | +---------------------------------
  69 | +
  70 | +When using an encrypted HD wallet, the keypool cannot be topped up without unlocking the wallet. This means that
  71 | +currently, in order to recover from a backup of an encrypted HD wallet, the user must unlock the wallet with a
  72 | +really long time out and manually trigger a rescan with `-rescan`, otherwise they risk missing some keys when

gmaxwell commented at 11:40 PM on September 7, 2017:

Rescan rpc (or command in the gui debug console). ... if you restart with -rescan you'll be relocked!

meshcollider commented at 11:49 PM on September 7, 2017:

Oops, fixed, thanks

fanquake added this to the milestone 0.15.0 on Sep 7, 2017

instagibbs commented at 11:56 PM on September 7, 2017: member

I don't think we have that RPC call, outside of importing a private key or something like that?

On Thu, Sep 7, 2017 at 4:41 PM, Gregory Maxwell notifications@github.com wrote:

@gmaxwell commented on this pull request.

In doc/release-notes.md https://github.com/bitcoin/bitcoin/pull/11280#discussion_r137681362:

+================

+Current SegWit Support +----------------------

+Version 0.15.0 supports adding a segregated witness address via the addwitnessaddress RPC, but +please note that this is a testing/expert RPC, which does not guarantee recovery from backup. Only use +this RPC if you know what you are doing. More complete support for segregated witness, including +wallet support, is coming in a next version.

+Rescanning with encrypted wallets +---------------------------------

+When using an encrypted HD wallet, the keypool cannot be topped up without unlocking the wallet. This means that +currently, in order to recover from a backup of an encrypted HD wallet, the user must unlock the wallet with a +really long time out and manually trigger a rescan with -rescan, otherwise they risk missing some keys when

Rescan rpc (or command in the gui debug console). ... if you restart with -rescan you'll be relocked!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/11280#pullrequestreview-61381630, or mute the thread https://github.com/notifications/unsubscribe-auth/AFgC0w3zgsdKF6NT7LjHMF3oL8MT8xD5ks5sgH9FgaJpZM4PQfrG .

in doc/release-notes.md:59 in 5e88581bb6 outdated

  52 | @@ -53,6 +53,27 @@ the Linux kernel, macOS 10.8+, and Windows Vista and later. Windows XP is not su
  53 |  Bitcoin Core should also work on most other Unix-like systems but is not
  54 |  frequently tested on them.
  55 |  
  56 | +Notes for 0.15.0
  57 | +================
  58 | +
  59 | +Current SegWit Support

fanquake commented at 9:04 AM on September 8, 2017:

nit s/Support/support

meshcollider commented at 11:46 AM on September 8, 2017:

Fixed, although title capitalisation is a bit inconsistent already in the file

in doc/release-notes.md:65 in 5e88581bb6 outdated

  60 | +----------------------
  61 | +
  62 | +Version 0.15.0 supports adding a segregated witness address via the `addwitnessaddress` RPC, but
  63 | +please note that this is a testing/expert RPC, which does not guarantee recovery from backup. Only use
  64 | +this RPC if you know what you are doing. More complete wallet support for segregated witness is coming
  65 | +in a next version.

fanquake commented at 9:07 AM on September 8, 2017:

Is this going to be in a point release, or 0.16.0 ? I think we should mention which here, because one could be a month away, while the other is 6 months or more. If not, instead of "is coming in a next version.", maybe just "will be available shortly." ?

meshcollider commented at 9:54 AM on September 8, 2017:

Segwit wallet support is aimed for 0.15.1 I believe? Also to me, "will be available shortly." sounds like it will somehow be added to 0.15.0, I like the emphasis on the new version

gmaxwell commented at 6:17 PM on September 8, 2017:

meshcollider is correct.

in doc/release-notes.md:72 in 5e88581bb6 outdated

  67 | +Rescanning with encrypted wallets
  68 | +---------------------------------
  69 | +
  70 | +As in previous versions, when using an encrypted HD wallet, the keypool cannot be topped up without unlocking
  71 | +the wallet. This means that currently, in order to recover from a backup of an encrypted HD wallet, the user
  72 | +must unlock the wallet with a really long time out and manually trigger a rescan, otherwise they risk missing

flack commented at 9:27 AM on September 8, 2017:

time out => timeout

meshcollider commented at 11:48 AM on September 8, 2017:

Fixed

instagibbs commented at 9:29 PM on September 8, 2017: member

Travis needs a kick post #11271 I think

ACK https://github.com/bitcoin/bitcoin/pull/11280/commits/8323db6fe6097994c3c3d4c7568bce66d780b691

sipa commented at 9:31 PM on September 8, 2017: member

ACK; needs rebase to fix travis

Add segwit and rescan notes to 0.15 release notes 93e2e5c269

laanwj commented at 10:27 PM on September 10, 2017: member

This has missed the 0.15.0 final tag, forgot about this one, sorry!

laanwj commented at 11:44 PM on September 10, 2017: member

Keeping this open for now, I'll see if I can still include this in the release notes uploaded to bitcoin.org etc.

dooglus commented at 6:27 PM on September 12, 2017: contributor

maximumCount - a number specifying the minimum number of UTXOs

This seems wrong. Doc string says:

      "maximumCount"     (numeric or string, default=unlimited) **Maximum** number of UTXOs

laanwj commented at 1:02 PM on September 14, 2017: member

Closing, this is now part of the 0.15.0 release notes on master.

This seems wrong. Doc string says:

Did not see this remark soon enough, so could not take this into account.

laanwj closed this on Sep 14, 2017

meshcollider deleted the branch on Sep 14, 2017

DrahtBot locked this on Sep 8, 2021

[0.15] Final to-do's for 0.15.0 release notes #11280

@gmaxwell commented on this pull request.