Use C++11's better capability of expressing an interface of a non-copyable class by publicly deleting its copy ctor and assignment operator instead of just declaring them private.
Refactor: Modernize disallowed copy constructors/assignment #11351
pull danra wants to merge 1 commits into bitcoin:master from danra:refactor/modernize-no-copy changing 7 files +30 −34-
danra commented at 10:10 AM on September 16, 2017: contributor
-
2a07f878a8
Refactor: Modernize disallowed copy constructors/assignment
Use C++11's better capability of expressing an interface of a non-copyable class by publicly deleting its copy ctor and assignment operator instead of just declaring them private.
- fanquake added the label Refactoring on Sep 16, 2017
- dcousens approved
-
practicalswift commented at 6:29 PM on September 16, 2017: contributor
utACK 2a07f878a80003f2142d5052d015a9ac81a3a6bc. Nice C++11 cleanup!
Perhaps add a note about this preference in the developer notes?
-
sipa commented at 4:38 AM on September 17, 2017: member
utACK 2a07f878a80003f2142d5052d015a9ac81a3a6bc
-
instagibbs commented at 6:57 PM on September 18, 2017: member
- gmaxwell approved
-
gmaxwell commented at 11:41 PM on September 21, 2017: contributor
utACK. Is this all the cases of unused copy constructors in the codebase? (no need for it to be now, but ifs not we should take a note to go do more of these).
- sipa merged this on Sep 22, 2017
- sipa closed this on Sep 22, 2017
- sipa referenced this in commit 6c4fecfaf7 on Sep 22, 2017
-
danra commented at 8:12 AM on September 22, 2017: contributor
@gmaxwell Yes.
On 22 Sep 2017, at 8:44, Pieter Wuille notifications@github.com wrote:
Merged #11351.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
- underdarkskies referenced this in commit 6e5f89d836 on Jul 3, 2018
- schancel referenced this in commit 6f47fcfacf on May 12, 2019
- jonspock referenced this in commit 923d6c2ca5 on Jun 13, 2019
- jonspock referenced this in commit 9266b492ef on Jun 13, 2019
- PastaPastaPasta referenced this in commit ff944c7870 on Dec 22, 2019
- PastaPastaPasta referenced this in commit 2a81aa05b6 on Jan 2, 2020
- PastaPastaPasta referenced this in commit a2695fc99b on Jan 4, 2020
- PastaPastaPasta referenced this in commit 409bb7da3e on Jan 12, 2020
- PastaPastaPasta referenced this in commit 57878fb4f5 on Jan 12, 2020
- PastaPastaPasta referenced this in commit 57916c2f01 on Jan 12, 2020
- PastaPastaPasta referenced this in commit d6c4485412 on Jan 12, 2020
- str4d referenced this in commit e591f94fcf on Jul 31, 2020
- zkbot referenced this in commit 5ef5d8d268 on Jul 31, 2020
- zkbot referenced this in commit 7d94064616 on Sep 29, 2020
- ckti referenced this in commit 7ec5543123 on Mar 28, 2021
- furszy referenced this in commit b04e1f5a90 on Jul 23, 2021
- furszy referenced this in commit 60d36292bc on Jul 26, 2021
- MarcoFalke locked this on Sep 8, 2021
Labels