[rpc] mempoolinfo should take ::minRelayTxFee into account #11475

pull mess110 wants to merge 1 commits into bitcoin:master from mess110:include_minRelayTxFee_in_getmempoolinfo_rpc changing 2 files +4 −1

mess110 commented at 4:45 PM on October 10, 2017: contributor

Fixes #6941 following #11410 (comment) 's suggestion

This takes care of the mentioned ticket without changing the behavior of https://github.com/bitcoin/bitcoin/pull/11410/files#diff-24efdb00bfbe56b140fb006b562cc70bL629

By modifying https://github.com/bitcoin/bitcoin/blob/5a9da37fb3f4b53f556e1d46509b94dc3c661d75/src/txmempool.cpp#L984 the syncing mempools becomes problematic as per #11410 (comment)

Same code causes different tests to fail: https://travis-ci.org/bitcoin/bitcoin/jobs/286128241 https://travis-ci.org/bitcoin/bitcoin/jobs/286128241 . I can't reproduce the problems locally, am I doing something wrong? travis sometimes fails unexpectedly
mess110 force-pushed on Oct 10, 2017
fanquake added the label RPC/REST/ZMQ on Oct 10, 2017
[rpc] mempoolinfo should take ::minRelayTxFee into account 149dffd3b2
mess110 force-pushed on Oct 11, 2017
ryanofsky commented at 5:12 PM on October 12, 2017: member

utACK 149dffd3b2a137d575ad19b8c0b13345efe3ada1. This is fine, but I definitely prefer #11410 because it cleaned up a bunch of code and got rid of weird edge cases.
mess110 commented at 5:17 PM on October 12, 2017: contributor

@ryanofsky I sort of prefer that too, but I couldn't figure out (yet) why I had those random mempool sync problems. Figured I would contribute some more to gain more knowledge, and figure that out at a later point in time.

Thanks for the review

Changing https://github.com/bitcoin/bitcoin/blob/master/src/txmempool.cpp#L986 is what causes the sporadic mempool sync problems
TheBlueMatt commented at 9:23 PM on October 17, 2017: member

utACK 149dffd3b2a137d575ad19b8c0b13345efe3ada1
jeffrade commented at 9:28 PM on December 20, 2017: contributor

@mess110 Looks like #6941 is only open for updating RPC help getmempoolinfo. Possible to make that update here in this PR? If not, I can make a new PR once yours is merged.
laanwj commented at 9:00 AM on December 23, 2017: member

utACK 149dffd

I definitely prefer #11410

Doesn't look like that one is still active, and it's been a long time, so I'm just going to merge this one.

Possible to make that update here in this PR? If not, I can make a new PR once yours is merged.

Yes, better to do that in a new change.
laanwj merged this on Dec 23, 2017
laanwj closed this on Dec 23, 2017
laanwj referenced this in commit 9bad8d6472 on Dec 23, 2017
mess110 deleted the branch on Dec 27, 2017
laanwj referenced this in commit a9a49e6e7e on Jan 4, 2018
PastaPastaPasta referenced this in commit a3d6179f99 on Jan 17, 2020
PastaPastaPasta referenced this in commit 3b2be135e8 on Jan 22, 2020
PastaPastaPasta referenced this in commit d7e6d2889f on Jan 22, 2020
PastaPastaPasta referenced this in commit 1a1807463c on Jan 29, 2020
PastaPastaPasta referenced this in commit 1bb00b2f43 on Jan 29, 2020
PastaPastaPasta referenced this in commit 33e89864b5 on Jan 29, 2020
PastaPastaPasta referenced this in commit b8c5d5d7ea on Jan 31, 2020
PastaPastaPasta referenced this in commit a0abbd47a4 on Feb 13, 2020
PastaPastaPasta referenced this in commit a2c8d92ee2 on Feb 27, 2020
PastaPastaPasta referenced this in commit 4e6cd82529 on Feb 27, 2020
PastaPastaPasta referenced this in commit 67cf9591c4 on Feb 27, 2020
ckti referenced this in commit 50b8a7d1ad on Mar 28, 2021
ckti referenced this in commit 41fa99cb01 on Mar 28, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6941 mempoolminfee returns incorrect data before the dynamic mempool limit has changed #11410 [rpc] [tests] mempoolminfee should not drop below minRelayTxFee #12001 [RPC] Adding ::minRelayTxFee amount to getmempoolinfo and updating help