[trivial] Make namespace explicit for is_regular_file #11495

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:explicit_is_regular_file changing 1 files +1 −1

jnewbery commented at 9:29 PM on October 13, 2017: member
is_regular_file resolves using argument dependent lookup. Make the namespace explicit so it's obvious where the function is defined.

For those not familiar with argument dependent lookups:
- http://en.cppreference.com/w/cpp/language/adl
- https://en.wikipedia.org/wiki/Argument-dependent_name_lookup
Thanks to C++ guru @ryanofsky for pointing this out to me.

[trivial] Make namespace explicit for is_regular_file

is_regular_file resolves using argument dependent lookup. Make the
namespace explicit so it's obvious where the function is defined.

f4c4e38884

ryanofsky commented at 9:55 PM on October 13, 2017: member

utACK f4c4e388843a9cf5fd4a289b1d6bce8eab6b2ce6
meshcollider commented at 10:55 PM on October 13, 2017: contributor

tACK https://github.com/bitcoin/bitcoin/pull/11495/commits/f4c4e388843a9cf5fd4a289b1d6bce8eab6b2ce6
promag commented at 11:01 PM on October 13, 2017: member

utACK f4c4e38.
fanquake added the label Refactoring on Oct 14, 2017
fanquake commented at 4:37 AM on October 14, 2017: member

ACK f4c4e38
practicalswift commented at 7:39 AM on October 16, 2017: contributor

utACK f4c4e388843a9cf5fd4a289b1d6bce8eab6b2ce6
laanwj merged this on Oct 18, 2017
laanwj closed this on Oct 18, 2017
laanwj referenced this in commit 50d72b3570 on Oct 18, 2017
jnewbery deleted the branch on Oct 18, 2017
schancel referenced this in commit 4f6623155e on Jul 18, 2019
jonspock referenced this in commit 5e904d9185 on Sep 5, 2019
jonspock referenced this in commit a6d7429e7f on Sep 6, 2019
proteanx referenced this in commit 8f6a3af862 on Sep 6, 2019
PastaPastaPasta referenced this in commit f0e724a260 on Dec 22, 2019
PastaPastaPasta referenced this in commit 07e00fa5ac on Jan 2, 2020
PastaPastaPasta referenced this in commit ba0b7368da on Jan 4, 2020
PastaPastaPasta referenced this in commit 0cac67b333 on Jan 12, 2020
PastaPastaPasta referenced this in commit d923a738b4 on Jan 12, 2020
PastaPastaPasta referenced this in commit 25c82bec1e on Jan 12, 2020
PastaPastaPasta referenced this in commit f266f7190d on Jan 12, 2020
PastaPastaPasta referenced this in commit 547231043a on Jan 12, 2020
PastaPastaPasta referenced this in commit 32cd6a4ec4 on Jan 12, 2020
PastaPastaPasta referenced this in commit 186edbeeeb on Jan 16, 2020
ckti referenced this in commit 17f9886f7a on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels