add missing debian contrib file to tarball #12051

1. 
   puchu commented at 9:08 PM on December 29, 2017: contributor

   the current release is missing the debian contrib folder, add it

2. fanquake added the label Build system on Dec 29, 2017
3. fanquake added the label Linux/Unix on Dec 29, 2017
4. 
   luke-jr commented at 10:49 PM on December 29, 2017: member

   utACK

5. 
   fanquake commented at 10:17 AM on December 30, 2017: member

   This is the reasoning as to why it was left out when DIST_CONTRIB was added (everything in debian/ is GPL2). Looks like that is still the case? Maybe now it's time to revisit writing our own desktop and protocol files?

6. 
   luke-jr commented at 10:20 AM on December 30, 2017: member

   Everything in git should also be in the dist tarball...

7. 
   ryanofsky commented at 5:52 PM on January 3, 2018: member

   utACK 036c32dea1e9ea73a55e19788c46b45938819765

8. 
   ryanofsky commented at 8:12 PM on January 8, 2018: member

   Last word on this was

   <wumpus> BlueMatt: luke-jr: making the tarball include all git files was discussed a few files already, I think everyone is okay with that in principle, it's just hard to unify with the 'make dist' makefile-isms

   from https://botbot.me/freenode/bitcoin-core-dev/msg/95342326/ which I'm not sure implies ack or nack.

9. 
   laanwj commented at 8:34 PM on March 5, 2018: member

   from https://botbot.me/freenode/bitcoin-core-dev/msg/95342326/ which I'm not sure implies ack or nack.

   Well I'd prefer a solution that makes the tarball contain everything, instead of doing it in dozen separate PRs.

10. laanwj assigned theuni on Mar 7, 2018
11. fanquake requested review from TheBlueMatt on Mar 24, 2018
12. DrahtBot closed this on Jul 20, 2018

    ---

13. DrahtBot reopened this on Jul 20, 2018

    ---

14. 
    puchu commented at 10:28 PM on July 20, 2018: contributor

    let's add missing files step by step this "all or nothing" approach leads to nothing. please define the problems/difficulties with this commit. afterwards we get this stuff solved and include it :)

15. 
    MarcoFalke commented at 12:57 AM on July 21, 2018: member

    @puchu contrib/debian is being moved to the packaging repo: See #13137

16. in Makefile.am:44 in 036c32dea1 outdated

      40 | @@ -41,6 +41,7 @@ DIST_DOCS = $(wildcard doc/*.md) $(wildcard doc/release-notes/*.md)
      41 |  DIST_CONTRIB = $(top_srcdir)/contrib/bitcoin-cli.bash-completion \
      42 |  	       $(top_srcdir)/contrib/bitcoin-tx.bash-completion \
      43 |  	       $(top_srcdir)/contrib/bitcoind.bash-completion \
      44 | +	       $(top_srcdir)/contrib/debian \
    

    ---

    ---

    

    MarcoFalke commented at 3:35 PM on April 8, 2019:

    	       $(top_srcdir)/contrib/debian/copyright \
    

    Since that is the only file left. And explicitly naming it prevents us from accidentally including files with an unsuitable license as pointed out in #12051 (comment)

17. MarcoFalke added the label Up for grabs on Apr 8, 2019
18. DrahtBot closed this on Apr 28, 2019

    ---

19. 
    DrahtBot commented at 7:12 PM on April 28, 2019: member

    <!--5d09a71f8925f3f132321140b44b946d-->The last travis run for this pull request was 281 days ago and is thus outdated. To trigger a fresh travis build, this pull request should be closed and re-opened.

20. DrahtBot reopened this on Apr 28, 2019

    ---

21. MarcoFalke removed the label Up for grabs on Apr 29, 2019
22. add missing debian contrib files to tarball 5d7ce74ab3
23. MarcoFalke renamed this:
    add missing debian contrib files to tarball
    add missing debian contrib file to tarball
    on Apr 29, 2019
24. MarcoFalke referenced this in commit 11e32e2fd1 on Apr 29, 2019
25. MarcoFalke merged this on Apr 29, 2019
26. MarcoFalke closed this on Apr 29, 2019

    ---

27. DrahtBot locked this on Dec 16, 2021

Contributors

puchuluke-jrfanquakeryanofskylaanwjMarcoFalkeDrahtBot

Review Requested
TheBlueMatt