depends: Remove ccache #12607

1. 
   fanquake commented at 10:25 pm on March 5, 2018: member

   After discussion with @theuni, we can possibly just remove ccache from depends entirely.

   Related to #12606

2. fanquake added the label Build system on Mar 5, 2018
3. 
   laanwj commented at 10:26 pm on March 5, 2018: member

   Concept ACK, let’s see what Travis says
4. 
   practicalswift commented at 6:10 am on March 6, 2018: contributor

   utACK ec7602b39eea0a7f8bc59eca3ac530e96e1e90e6
5. 
   MarcoFalke commented at 1:13 pm on March 6, 2018: member

   Looks like configure picked up the ccache: checking if ccache should be used... yes

   utACK ec7602b

6. 
   jonasschnelli commented at 1:36 pm on March 6, 2018: contributor

   Lets see the gitian builder says: https://bitcoin.jonasschnelli.ch/build/524 https://bitcoin.jonasschnelli.ch/build/526
7. fanquake renamed this:
   [WIP] depends: Remove ccache
   depends: Remove ccache
   on Mar 6, 2018
8. 
   MarcoFalke commented at 2:34 pm on March 6, 2018: member

   @jonasschnelli ’s gitian build seems fine
9. 
   laanwj commented at 2:35 pm on March 6, 2018: member

   What we still need to check is whether travis caches the ccache result, even though ~/.ccache is no longer in the list. I’m not sure how, is it possible to inspect the travis cache?

   Edit: I tried through the GUI, as well as the travis command line tool, but with neither I was able to locate the cache for this PR. This might either mean it doesn’t exist, or I couldn’t get at it for another reason (e.g. some upper limit to the number of shown caches).

   Seems the former. At the end of the travis logs it says:

   0store build cache
   1nothing changed, not updating cache
   

   It’s not writing the cache at all because it detects no changes?!

10. laanwj requested review from theuni on Mar 6, 2018
11. depends: Remove ccache cc879675e1
12. in .travis.yml:9 in ec7602b39e outdated

     2@@ -3,10 +3,10 @@ dist: trusty
     3 os: linux
     4 language: minimal
     5 cache:
     6+  ccache: true
     7   directories:
     8   - depends/built
     9   - depends/sdk-sources
    10-  - $HOME/.ccache
    

    ---

    ---

    

    laanwj commented at 3:26 pm on March 6, 2018:

    My guess is that this needs to be re-added
13. fanquake force-pushed on Mar 6, 2018
14. 
    randolf commented at 4:01 pm on March 6, 2018: contributor

    Just in case it’s helpful, I successfully complied this on NetBSD 7.0 (64-bit). These are the commands I used:

    git clone https://www.github.com/fanquake/bitcoin/ cd bitcoin git checkout ccache-removal ./autogen.sh ./configure CPPFLAGS="-I/usr/pkg/include" LDFLAGS="-L/usr/pkg/lib" BOOST_CPPFLAGS="-I/usr/pkg/include" BOOST_LDFLAGS="-L/usr/pkg/lib" gmake

    If you’d like me to try building with different parameters, or check for the presence of certain files/directories, please let me know.

15. 
    laanwj commented at 4:03 pm on March 6, 2018: member

    @randolf Thanks for testing, however this does not affect normal autotools builds, if you don’t use the depends system. And I don’t think the depends system works on NetBSD (though never tried).
16. 
    randolf commented at 4:11 pm on March 6, 2018: contributor

    @laanwj I don’t know enough about the “depends system” to provide helpful perspective there, but I’d be happy to try if there are some instructions somewhere that I can follow.
17. theuni approved
18. 
    theuni commented at 7:19 pm on March 6, 2018: member

    ACK cc879675e16c310f3ce3f2387b7aa966e64e4352
19. 
    MarcoFalke commented at 11:11 pm on March 6, 2018: member

    re-utACK cc879675e16c310f3ce3f2387b7aa966e64e4352

    Caching works on arm and osx cross-builds at least

20. 
    laanwj commented at 11:14 pm on March 6, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/12607/commits/cc879675e16c310f3ce3f2387b7aa966e64e4352 - will merge this tomorrow after the meeting to minimize the amount of interference with ongoing travis testing
21. 
    MarcoFalke commented at 2:13 am on March 8, 2018: member

    @laanwj I assume the meeting is over?
22. MarcoFalke merged this on Mar 8, 2018
23. MarcoFalke closed this on Mar 8, 2018

    ---

24. MarcoFalke referenced this in commit 29fad97c32 on Mar 8, 2018
25. 
    ryanofsky commented at 3:06 pm on March 8, 2018: member

    The travis builds on all my PR’s seem to be failing with errors like:

    0$ if [ -z "$NO_DEPENDS" ]; then depends/$HOST/native/bin/ccache --max-size=$CCACHE_SIZE; fi
    1/home/travis/.travis/job_stages: line 57: depends/x86_64-unknown-linux-gnu/native/bin/ccache: No such file or directory
    

    An example is https://travis-ci.org/bitcoin/bitcoin/jobs/350509177#L1055

26. 
    MarcoFalke commented at 3:19 pm on March 8, 2018: member

    @ryanofsky This is a travis bug. The command you mention above was removed from the travis yaml, it shouldn’t be executed at all.

    You can either ignore the failure or rebase your pull request on master. (Just changing the commit id via EDITOR=true git commit --ammend might be enough, but I haven’t checked)

    Edit: Just checked that rebase is not needed. You can just change the commit id

27. willyko referenced this in commit ba390a89be on Apr 20, 2018
28. codablock referenced this in commit 1ef70ac9ef on Nov 4, 2019
29. fanquake deleted the branch on Dec 20, 2019
30. barrystyle referenced this in commit 347d8b8bea on Jan 22, 2020
31. deadalnix referenced this in commit 321a3c2e09 on Mar 19, 2020
32. ftrader referenced this in commit 82462095f1 on May 19, 2020
33. DrahtBot locked this on Dec 16, 2021

Contributors
fanquake laanwj practicalswift MarcoFalke jonasschnelli randolf theuni ryanofsky

Labels
Build system