RPC: Support addnode onetry without making the connection priviliged #12674

 194 | @@ -195,17 +195,16 @@ UniValue addnode(const JSONRPCRequest& request)
 195 |      std::string strCommand;
 196 |      if (!request.params[1].isNull())
 197 |          strCommand = request.params[1].get_str();
 198 | -    if (request.fHelp || request.params.size() != 2 ||
 199 | +    if (request.fHelp || request.params.size() < 2 || request.params.size() > 3 ||
 200 |          (strCommand != "onetry" && strCommand != "add" && strCommand != "remove"))
 201 |          throw std::runtime_error(
 202 | -            "addnode \"node\" \"add|remove|onetry\"\n"
 203 | +            "addnode \"node\" \"add|remove|onetry\" (privileged)\n"

---

 222 | -        g_connman->OpenNetworkConnection(addr, false, nullptr, strNode.c_str(), false, false, true);
 223 | +        g_connman->OpenNetworkConnection(addr, false, nullptr, strNode.c_str(), false, false, privileged);
 224 |          return NullUniValue;
 225 |      }
 226 |  
 227 | +    if (privileged) {

---

 213 | @@ -215,14 +214,19 @@ UniValue addnode(const JSONRPCRequest& request)
 214 |          throw JSONRPCError(RPC_CLIENT_P2P_DISABLED, "Error: Peer-to-peer functionality missing or disabled");
 215 |  
 216 |      std::string strNode = request.params[0].get_str();
 217 | +    const bool privileged = request.params[2].isNull() ? true : request.params[2].get_bool();

---

 223 | +        g_connman->OpenNetworkConnection(addr, false, nullptr, strNode.c_str(), false, false, privileged);
 224 |          return NullUniValue;
 225 |      }
 226 |  
 227 | +    if (privileged) {
 228 | +        throw JSONRPCError(RPC_INVALID_PARAMETER, "Unprivileged connections are only supported for the \"onetry\" command for now");

---

 206 | -            "Nodes added using addnode (or -connect) are protected from DoS disconnection and are not required to be\n"
 207 | -            "full nodes/support SegWit as other outbound peers are (though such peers will not be synced from).\n"
 208 |              "\nArguments:\n"
 209 |              "1. \"node\"     (string, required) The node (see getpeerinfo for nodes)\n"
 210 |              "2. \"command\"  (string, required) 'add' to add a node to the list, 'remove' to remove a node from the list, 'onetry' to try a connection to the node once\n"
 211 | +            "3. privileged (boolean, optional, default=true) If true, nodes added will be protected from DoS disconnection and not required to be full nodes or support segwit as other outbound peers are (though such peers will not be synced from). Only supported for command \"onetry\" for now.\n"

---

 223 | -                "full nodes/support SegWit as other outbound peers are (though such peers will not be synced from).\n",
 224 | +                "Or try a connection to a node once.\n",
 225 |                  {
 226 |                      {"node", RPCArg::Type::STR, /* opt */ false, /* default_val */ "", "The node (see getpeerinfo for nodes)"},
 227 |                      {"command", RPCArg::Type::STR, /* opt */ false, /* default_val */ "", "'add' to add a node to the list, 'remove' to remove a node from the list, 'onetry' to try a connection to the node once"},
 228 | +                    {"privileged", RPCArg::Type::BOOL, /* opt */ true, /* default_val */ "true", "If true, nodes added will be protected from DoS disconnection and not required to be full nodes or support segwit as other outbound peers are (though such peers will not be synced from). Only supported for command \"onetry\" for now."},

---

 227 | @@ -228,17 +228,16 @@ static UniValue addnode(const JSONRPCRequest& request)
 228 |      std::string strCommand;
 229 |      if (!request.params[1].isNull())
 230 |          strCommand = request.params[1].get_str();
 231 | -    if (request.fHelp || request.params.size() != 2 ||
 232 | +    if (request.fHelp || request.params.size() < 2 || request.params.size() > 3 ||

---