doc: Use bitcoind in Tor documentation #12877

No description provided.

What does -daemon have to do with Tor?

bitcoind -proxy=127.0.0.1:9050 -externalip=57qr3yd1nyntf5k.onion -listen That starts the bitcoin server, but not as a background process. You are now stuck and do not return to the console, it hangs because it is running. Once you exit the terminal or hit ctrl+C, the process terminates.

./bitcoind -daemon -proxy=127.0.0.1:9050 -externalip=57qr3yd1nyntf5k.onion -listen Now the Bitcoin server starts, forks as a background process, then properly (exits), returns to the console.

Sure, but there are many other options people may want to combine with the Tor specific ones (for example -logtimestamps or -dbcache or -txindex or -maxconnections). Some of these may be necessary in your particular setup; others may be personal preference.

But this document isn't trying to give a comprehensive overview of all options; just the Tor specific ones. There are probably dozens of others that could be listed.

Hmmm, can't imagine someone not using -daemon. The others options mentioned, -logtimestamps or -dbcache or -txindex or -maxconnections are definitely not required. In my Debian environment, I would never have a persistent process without it.

How about the first correction I made, where it states bitcoin instead of bitcoind?

	./bitcoin -proxy=127.0.0.1:9050
	./bitcoind -daemon -proxy=127.0.0.1:9050

or exclude -daemon

	./bitcoin -proxy=127.0.0.1:9050
	./bitcoind -proxy=127.0.0.1:9050

My apologies, daemon=1 can be configured in bitcoin.conf...gotchya Gonna resubmit pull request...

All options can be configured in bitcoin.conf or on the command line.

Yes, the first fix (bitcoind instead of bitcoin) is great. There is another instance of that at the bottom of the file, btw.

Which options you run with depend on your setup. For high performance systems, running without dbcache may be unacceptably slow for example. If you think nobody would want to run without daemon (I personally always do as well), perhaps that would be a good reason to discuss changing the default (but do so in a separate PR).

Updated Pull Request...

Nice catch, fixed both instances of bitcoin replaced with bitcoind, other previous changes including -daemon were discarded, pull request ready.

@knoxcard Can you please squash your commits

utACK on the bitcoin to bitcoind changes assuming squash into one commit

ACK after squash

My apologies for not responding sooner. I've never squashed a commit, but I am committed to trying it. lol, lil Git humor for you there. I'll try to get around to this first thing tomorrow.

***Would be wonderful it GitHub could automate these kind of tasks or just create a "squash commit" button

@knoxcard

$ git checkout patch-1
$ git rebase -i HEAD~3 # mark the two last commits as fixups.
$ git push -f

Looks like you have enabled maintainers pushing to your branch - pushed a squashed version. (though if you can, read up on git so you can do this yourself next time)

Thank You I am a super technical guy and use git all time. Getting super late over here, gonna head to sleep, but I need to know how to squash by tomorrow.

I submitted these changes using the Github web interface. Where would I have executed those commands?

If I open a new console window in Windows, then something like.. mkdir myproject git init git fetch what? Am I missing something?

Nice work gentlemen, may your Bitcoin be plentiful as the years pass.

Where would I have executed those commands? If I open a new console window in Windows, then something like.. mkdir myproject git init git fetch what?

No, you'd git clone your own fork:

$ git clone https://github.com/knoxcard/bitcoin
$ cd bitcoin

and then do the steps as practicalswift pointed out: #12877 (comment)