Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 #13154

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/flushed changing 2 files +2 −2

ryanofsky commented at 2:09 PM on May 2, 2018: member

No description provided.
Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 21f5680553
fanquake added the label Docs on May 2, 2018
fanquake commented at 2:12 PM on May 2, 2018: member

utACK 21f5680
promag commented at 2:14 PM on May 2, 2018: member

utACK 21f5680.

laanwj commented at 2:19 PM on May 2, 2018: member

Gah, apparently the script in 50b6533aa2a9ccbc758aaf5a9f6dfa1c9433bff1 didn't cover these.

    -BEGIN VERIFY SCRIPT-
    sed -i 's/SetBestChain/ChainStateFlushed/g' src/validationinterface.h src/validationinterface.cpp src/wallet/wallet.h src/wallet/wallet.cpp src/validation.cpp src/index/txindex.h src/index/txindex.cpp
    -END VERIFY SCRIPT-

MarcoFalke commented at 2:27 PM on May 2, 2018: member

Yeah, imo git grep -l foo ./src/ is less fragile than hardcoding all the file names.
practicalswift commented at 3:39 PM on May 2, 2018: contributor

utACK 21f56805531c4b2954d0aaffa34c83f37ed8f9c0
laanwj commented at 10:37 AM on May 3, 2018: member

Yeah, imo git grep -l foo ./src/ is less fragile than hardcoding all the file names.

~~Yes, though, please use git ls-files in that case otherwise it'll search/replace in executables and IDE metadata files unrelated to git too...~~
laanwj merged this on May 3, 2018
laanwj closed this on May 3, 2018
laanwj referenced this in commit 11adab39e6 on May 3, 2018
practicalswift commented at 11:15 AM on May 3, 2018: contributor

@laanwj git grep will only search in the repo, which is what we want right? :-)
laanwj commented at 12:25 PM on May 3, 2018: member

@practicalswift You're right, that's what it does by default, forgot about that.
UdjinM6 referenced this in commit 3b3579200d on May 21, 2021
TheArbitrator referenced this in commit 06c597c6d7 on Jun 4, 2021
UdjinM6 referenced this in commit 0d3386bae5 on Jun 5, 2021
UdjinM6 referenced this in commit 732697586f on Jun 5, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels