trivial: Fixed typos and cleaned up language #13255
pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:language-cleanup changing 11 files +48 −48-
fanquake commented at 3:39 am on May 17, 2018: memberThis rebases and fixes some of the outstanding nits in #13010. Let either merge quickly or close for now.
-
fanquake added the label Docs on May 17, 2018
-
fanquake force-pushed on May 17, 2018
-
practicalswift commented at 4:57 am on May 17, 2018: contributor
ACK modulo fixing:
0This diff appears to have added new lines with trailing whitespace. 1The following changes were suspected: 2diff --git a/doc/tor.md b/doc/tor.md 3@@ -104,9 +105,9 @@ To show verbose debugging information, pass `-debug=tor`. 4+are seen with `-debug=tor` they can be resolved by adding both the user running Tor and 5^---- failure generated from contrib/devtools/lint-whitespace.sh -
Empact commented at 7:26 am on May 17, 2018: memberGood overall, but I think there’s some language confusion in the changes. E.g. Bitcoin is a proper noun for the currency / project / network, hence capitalized. “bitcoin” is used as shorthand for Bitcoin Core and arguably serves well lower-case. Bitcoin-Qt is the actual executable name of the wallet software, and is capitalized in its naming.
-
in doc/README.md:6 in e188a22536 outdated
2@@ -3,13 +3,13 @@ Bitcoin Core 3 4 Setup 5 --------------------- 6-Bitcoin Core is the original Bitcoin client and it builds the backbone of the network. It downloads and, by default, stores the entire history of Bitcoin transactions (which is currently more than 100 GBs); depending on the speed of your computer and network connection, the synchronization process can take anywhere from a few hours to a day or more. 7+Bitcoin Core, the original bitcoin client, builds the network's backbone. It downloads and, by default, stores the entire history of bitcoin transactions (which is currently more than 160 GB). Depending on the speed of your computer and network connection, the synchronization process can take anywhere from a few hours to over a day.
Empact commented at 7:32 am on May 17, 2018:I like the author’s suggestion of a different first sentence, which could be integrated: “Bitcoin Core is the original and current reference implementation of the Bitcoin network” #13010 (review)MarcoFalke commented at 10:13 pm on May 17, 2018: memberI guess thebitcoin->Bitcoin Corereplacements make sense. The other changes are hard to review for non-native speakers, so I’d suggest dropping them.fanquake force-pushed on May 26, 2018sipa commented at 1:44 am on May 28, 2018: memberI think we generally use ‘bitcoin’ to refer to the currency, and “Bitcoin” for the project/network/technology.DrahtBot added the label Needs rebase on Jun 7, 2018fanquake force-pushed on Jun 26, 2018DrahtBot removed the label Needs rebase on Jun 27, 2018fanquake force-pushed on Aug 2, 2018fanquake force-pushed on Aug 2, 2018fanquake commented at 9:00 am on August 2, 2018: memberRebased, dropped the more verbose changes from the first commit, and cherry picked another related commit.practicalswift commented at 9:53 am on August 2, 2018: contributorACK 756d4d38b21f09f76b3d6fcf7d9189345ea834baVarunram commented at 10:01 am on August 2, 2018: contributorThanks, looks good.in doc/tor.md:10 in 756d4d38b2 outdated
7 configure Tor. 8 9 10-## 1. Run bitcoin behind a Tor proxy 11+## 1. Run Bitcoin Core behind a Tor proxy 12+---------------------------------
MarcoFalke commented at 12:05 pm on August 2, 2018:Unrelated------------------------
fanquake commented at 1:28 pm on August 2, 2018:Thanks, fixed.MarcoFalke commented at 12:05 pm on August 2, 2018: memberutACK 756d4d38b21f09f76b3d6fcf7d9189345ea834batrivial: Fixed typos and cleaned up language 3be70ba400trivial: correct typos d5f745a5c7fanquake force-pushed on Aug 2, 2018practicalswift commented at 1:33 pm on August 2, 2018: contributorACK d5f745a5c76ad5fbcc9a20fe128806e39de52a2cpromag commented at 1:52 pm on August 2, 2018: memberACK d5f745a without squash to keep authors.MarcoFalke merged this on Aug 2, 2018MarcoFalke closed this on Aug 2, 2018
MarcoFalke referenced this in commit 1ef57a96b8 on Aug 2, 2018fanquake deleted the branch on Aug 2, 2018UdjinM6 referenced this in commit eac7a01094 on Jun 29, 2021UdjinM6 referenced this in commit e6c9bbd743 on Jun 29, 2021UdjinM6 referenced this in commit d64541b7ef on Jul 1, 2021UdjinM6 referenced this in commit 3e9bf2a8c8 on Jul 2, 2021UdjinM6 referenced this in commit 8e3565df8e on Jul 2, 2021MarcoFalke locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-27 09:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-27 09:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me