OSX -> macOS #13609

1. 
   rex4539 commented at 12:28 pm on July 7, 2018: contributor

   Replaced OSX with macOS in places I thought were appropriate and added a couple of small unification changes.
2. fanquake added the label Docs on Jul 7, 2018
3. fanquake added the label macOS on Jul 7, 2018
4. 
   Empact commented at 2:38 pm on July 7, 2018: member

   Related prior work: #13366
5. in src/tinyformat.h:158 in 9d2ae302a0 outdated

   155 #   define TINYFORMAT_OLD_LIBSTDCPLUSPLUS_WORKAROUND
   156 #endif
   157 
   158 #ifdef __APPLE__
   159-// Workaround OSX linker warning: Xcode uses different default symbol
   160+// Workaround macOS linker warning: Xcode uses different default symbol
   

   ---

   ---

   

   MarcoFalke commented at 7:15 am on July 8, 2018:

   Please report this upstream instead.

   ---

   

   rex4539 commented at 7:30 am on July 8, 2018:

   https://github.com/c42f/tinyformat/pull/52
6. in src/qt/guiutil.h:237 in 9d2ae302a0 outdated

   233@@ -234,7 +234,7 @@ namespace GUIUtil
   234     };
   235 
   236 #if defined(Q_OS_MAC)
   237-    // workaround for Qt OSX Bug:
   238+    // workaround for Qt macOS Bug:
   

   ---

   ---

   

   MarcoFalke commented at 7:17 am on July 8, 2018:

   Can be fixed up as part of #13362 or not at all.

   ---

   

   fanquake commented at 3:05 am on July 9, 2018:

   Should be going away in #13617. I can cherry-pick some of the other changes here into that.
7. 
   MarcoFalke commented at 7:19 am on July 8, 2018: member

   Tend to NACK here for the comments given above. Imo, it would be more helpful if contrib/gitian-build.sh was rewritten to python to make it more user friendly. I don’t see any increase in user-friendliness in this pull request as is.
8. OSX -> macOS 8895c2f681
9. 
   rex4539 commented at 7:52 am on July 8, 2018: contributor

   Addressed the first comment. There is nothing I can do about the second comment :)
10. 
    laanwj commented at 1:02 pm on July 9, 2018: member

    Agree with @marcofalke here on ~NACK. I think #13366 did the important changes here. We can forever keep creating PRs to change straggler occurrences in obscure places, but the added value is little compared to the overhead.

    Also agree with converting contrib/gitian-build.sh to python.

11. laanwj closed this on Jul 9, 2018

    ---

12. MarcoFalke locked this on Sep 8, 2021

Contributors
rex4539 Empact MarcoFalke fanquake laanwj

Labels
Docs macOS