Drop dead code from Stacks #13633

pull Empact wants to merge 1 commits into bitcoin:master from Empact:stacks changing 1 files +2 −9

Empact commented at 9:33 AM on July 11, 2018: member

Stacks is local to this file, and only used in DataFromTransaction, so it's easy to confirm this code is unused.
Empact commented at 9:34 AM on July 11, 2018: member

Split from #13266 /cc @achow101
fanquake added the label Refactoring on Jul 11, 2018

in src/script/sign.cpp:254 in b170cb1776 outdated

 250 | @@ -251,18 +251,10 @@ struct Stacks
 251 |      std::vector<valtype> script;
 252 |      std::vector<valtype> witness;
 253 |  
 254 | -    Stacks() {}
 255 | -    explicit Stacks(const std::vector<valtype>& scriptSigStack_) : script(scriptSigStack_), witness() {}
 256 | +    Stacks() = delete;

promag commented at 1:56 PM on July 12, 2018:

Also disallow implicit copy constructor?

    Stacks(const Stacks&) = delete;

promag commented at 1:58 PM on July 12, 2018: member

Tested ACK b170cb1.
practicalswift commented at 2:08 PM on July 12, 2018: contributor

Concept ACK

Drop dead code from Stacks

Stacks is local to this file, and only used in DataFromTransaction, so
it's easy to confirm this code is unused.

5617840392

Empact force-pushed on Jul 12, 2018
sipa commented at 2:50 AM on July 14, 2018: member

utACK 5617840392dad8c00c0e4216f1a536daaa9dd4bd
MarcoFalke commented at 12:33 PM on July 14, 2018: member

utACK 5617840
fanquake commented at 10:10 AM on July 18, 2018: member

utACK 5617840
fanquake added this to the "Mergeable" column in a project

laanwj commented at 2:21 PM on July 22, 2018: member

utACK 5617840392dad8c00c0e4216f1a536daaa9dd4bd
laanwj merged this on Jul 22, 2018
laanwj closed this on Jul 22, 2018
laanwj referenced this in commit 6deac922e3 on Jul 22, 2018
fanquake removed this from the "Mergeable" column in a project

jasonbcox referenced this in commit 06265e7af0 on Dec 20, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels