0.16: Remaining backports for 0.16.2

MarcoFalke commented at 2:06 pm on July 12, 2018: member

Some gui/doc/rpc/qa backports

Remove useless mapRequest tracking that just effects Qt display.

I thought we had removed this a long time ago, TBH, its really
confusing feedback to users that we display whether a tx was
broadcast to immediate neighbor nodes, given that has little
indication of whether the tx propagated very far.

Github-Pull: #13622
Rebased-From: beef7ec4be725beea870a2da510d2817487601ec

c04a4a5ae9

[tests] Fixed intermittent failure in p2p_sendheaders.py.

Added handling for the case where headers are announced over more than one message.
refs #12453

Github-Pull: #13192
Rebased-From: 12d1b77f7eb2ca274890d9fb45d6c19a40ba8f74

79c4fff9ed

qa: Fix wallet_listreceivedby race

Github-Pull: #13304
Rebased-From: fa865efa4a21ae08be8b4c390b7661182e0b415b

cbdabef35e

qt: Avoid resetting on resetguisettigs=0

Github-Pull: #12793
Rebased-From: 342fb8034640d4393771899dc132c9e3b170b369

cf6feb7837

[trivial] Add newlines to end of log messages.

Log messages should terminate with a '\n', or the following log will be
written to the same line without a timestamp. Fix a couple of cases
where the message is not terminated with a \n.

Github-Pull: #12887
Rebased-From: 5b10ab0116245ee73b493e2248ad2f8bb8e34f21

2291774bd5

rpc: fix type mistmatch in listreceivedbyaddress

Github-Pull: #12837
Rebased-From: 05c03d1249c6fe30dbfcea9f3f3a3bd02106035b

bf1f150190

[rpcwallet] Clamp walletpassphrase value at 100M seconds

Larger values seem to trigger a bug on macos+libevent (resulting in the
rpc server stopping).

Github-Pull: #12905
Rebased-From: 662d19ff7217d0e6c7975ca311933f640955a53e

cfc6f7413b

MarcoFalke added the label Backport on Jul 12, 2018

MarcoFalke added this to the milestone 0.16.2 on Jul 12, 2018

fanquake commented at 2:13 pm on July 12, 2018: member

Looks like this is missing #13452 and #13437 ?

MarcoFalke commented at 2:18 pm on July 12, 2018: member

@fanquake thanks. I will go through all master changes again and then include those two as well (and any other I find on the way)

Make tests pass after 2020

also test that 64 bit integers are properly handled

Github-Pull: #13061
Rebased-From: 3ee4be10500710fc8e9b03acf974fd81224c05c4

170b309981

Fix incorrect tests

Github-Pull: #13545
Rebased-From: c6fd0df4efcd9f75c43ff527fd57fe43bc47a474

10621995ed

Remove boost dependency (boost/assign/std/vector.hpp)

Github-Pull: #13545
Rebased-From: 962d8eed5bdbe62b9926f01cb85bdce9d435d3d6

e15e3a9ddd

wallet: Erase wtxOrderd wtx pointer on removeprunedfunds

Github-Pull: #13437
Rebased-From: faa18ca046e9043b2cf68cb1bd17cc8c60fe26d9

ed82e7176d

MarcoFalke force-pushed on Jul 13, 2018

have verifytxoutproof check the number of txns in proof structure

Github-Pull: #13452
Rebased-From: ed82f1700006830b6fe34572b66245c1487ccd29

6b9dc8ceae

[qa] Add a test for merkle proof malleation

Github-Pull: #13452
Rebased-From: d280617bf569f84457eaea546541dc74c67cd1e4

b72c0bd4c9

Consensus: Fix bug when compiler do not support __builtin_clz*

#ifdef is not correct since defination is defined to 0 or 1. Should change to #if

Github-Pull: #12573
Rebased-From: 18307849b405f9e2067eaa8091b105838f413707

88d1a649a2

Fix csBestBlock/cvBlockChange waiting in rpc/mining

Github-Pull: #12743
Rebased-From: 45dd13503918e75a45ce33eb5c934b998790fdc8

657dfc5bca

MarcoFalke force-pushed on Jul 13, 2018

luke-jr commented at 5:11 pm on July 13, 2018: member

Missing:

#12859 (somewhat important): Bugfix: Include for std::unique_ptr
#12432: [qt] send: Clear All also resets coin control options
#12573: Fix compilation when compiler do not support __builtin_clz*
#12617: gui: Show messages as text not html
#12743: Fix csBestBlock/cvBlockChange waiting in rpc/mining
#12793: qt: Avoid reseting on resetguisettigs=0
#13149: Handle unsuccessful fseek(…):s

MarcoFalke commented at 5:15 pm on July 13, 2018: member

#12859 (somewhat important): Bugfix: Include for std::unique_ptr #12793: qt: Avoid reseting on resetguisettigs=0

Both are included. Thanks, will look at the remaining ones…

[qt] send: Clear All also resets coin control options

Github-Pull: #12432
Rebased-From: f506c0a7f8ea6bae089177884e44e38cd2bfeb23

f78e7f6589

gui: Show messages as text not html

Currently, error messages (such as InitError) are displayed as-is, which
means Qt does auto detection on the format.

This means that it's possible to inject HTML from the command line
though e.g. specifying a wallet name with HTML in it. This isn't
a direct security risk because fetching content from internet is
disabled (and as far as I know we never report strings received
from the network this way). However, it can be confusing.

So explicitly force the format as text.

Github-Pull: #12617
Rebased-From: 6fbc0986fa2d49a1cb65b60eca71c25c84842a54

21dd5127a4

MarcoFalke commented at 5:35 pm on July 13, 2018: member

Done

gmaxwell commented at 6:12 pm on July 13, 2018: contributor

ACK

achow101 commented at 10:25 pm on July 13, 2018: member

ACK

fanquake commented at 3:54 am on July 14, 2018: member

utACK https://github.com/bitcoin/bitcoin/pull/13644/commits/21dd5127a423f38712dcdcef4002e714e8276bd2

qa: Initialize lockstack to prevent null pointer deref

Github-Pull: #13300
Rebased-From: fa9da85b7cc759d06bc24854be2bad0ea87b6006

d9c563095d

MarcoFalke force-pushed on Jul 14, 2018

MarcoFalke commented at 3:24 pm on July 14, 2018: member

Pushed a commit to fix a test debugging issue reported by a user on the bitcoin-dev mailing list.

https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-July/016255.html

sipa commented at 7:07 pm on July 14, 2018: member

utACK d9c563095d71055ff054d3a27e11a12d3d1ec92f

MarcoFalke assigned laanwj on Jul 14, 2018

gmaxwell commented at 9:57 am on July 15, 2018: contributor

re-ACK

fanquake commented at 12:30 pm on July 15, 2018: member

re-utACK d9c5630

laanwj commented at 12:49 pm on July 16, 2018: member

utACK d9c563095d71055ff054d3a27e11a12d3d1ec92f

laanwj merged this on Jul 16, 2018

laanwj closed this on Jul 16, 2018

laanwj referenced this in commit 7f27af22b0 on Jul 16, 2018

MarcoFalke deleted the branch on Jul 16, 2018

MarcoFalke locked this on Sep 8, 2021

0.16: Remaining backports for 0.16.2 #13644