contrib: Remove debian and rpm subfolder #13809

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-debianContrib changing 33 files +6 −1660

MarcoFalke commented at 5:42 PM on July 30, 2018: member
The folders are now located here:
- https://github.com/bitcoin-core/packaging/tree/master/debian
- https://github.com/bitcoin-core/packaging/tree/master/rpm
Note that I kept the copyright file, so that it can be updated for our purposes in the commit that adds new files.
MarcoFalke added the label Scripts and tools on Jul 30, 2018
MarcoFalke force-pushed on Jul 30, 2018
MarcoFalke renamed this:
~~contrib: Remove debian subfolder~~
contrib: Remove debian and rpm subfolder
on Jul 30, 2018
contrib: Remove debian and rpm subfolders fa0e1e2f63
MarcoFalke force-pushed on Jul 30, 2018
practicalswift commented at 7:51 PM on July 30, 2018: contributor

utACK fa0e1e2f630e6ca6cdfca64d8d92a7f0f85baa4d

1654 lines (re)moved – very nice!
kallewoof commented at 9:05 PM on July 30, 2018: member

utACK fa0e1e2

Small diff for debian dir, but nothing significant. Diff for rpm dir is clean.
laanwj commented at 9:32 AM on July 31, 2018: member

Thanks for picking this up, utACK fa0e1e2f630e6ca6cdfca64d8d92a7f0f85baa4d

Edit: huh that was strange, looked like github lost my comment at first
fanquake commented at 11:31 AM on July 31, 2018: member
utACK fa0e1e2

Only nit could be to drop:
```
Files: debian/*
Copyright: 2010-2011, Jonas Smedegaard <dr@jones.dk>
           2011, Matt Corallo <matt@bluematt.me>
License: GPL-2+
```
from contrib/debian/copyright, as copyright is now the only file in debian/*.

Edit: @MarcoFalke What do you mean by:

Note that I kept the copyright file, so that it can be updated for our purposes in the commit that adds new files.

If we are copying the files from /packaging/ back in here pre-release then the above nit is redundant.
MarcoFalke commented at 12:06 PM on July 31, 2018: member

@bugthebluematt
TheBlueMatt commented at 3:37 PM on July 31, 2018: member

Currently people tend to be pretty good about updating contrib/debian/copyright when things change, which is super nice cause I won't ever keep track of it. It may make sense to move it from contrib/debian/copyright to contrib/copyright or something like that.
MarcoFalke commented at 3:55 PM on July 31, 2018: member

It is still in the debian format, so I think it makes sense to keep in the debian folder. (Also I don't feel like updating all the internal and external links to the file)
MarcoFalke commented at 3:57 PM on July 31, 2018: member

If anyone feels strongly about that, it should be done in a separate commit to not invalidate the previous review.
MarcoFalke merged this on Jul 31, 2018
MarcoFalke closed this on Jul 31, 2018
MarcoFalke referenced this in commit 77168f766f on Jul 31, 2018
MarcoFalke deleted the branch on Jul 31, 2018
UdjinM6 referenced this in commit b1fc14d1d2 on Jun 29, 2021
UdjinM6 referenced this in commit 7798ccb9c7 on Jun 29, 2021
UdjinM6 referenced this in commit 4ea2150903 on Jul 2, 2021
UdjinM6 referenced this in commit 1dcbe7aa5d on Jul 4, 2021
UdjinM6 referenced this in commit 03d01caaf7 on Jul 6, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#15068 Install icon & .desktop file to XDG data