docs: fix typo in translation_process.md #13857

pull johnlow95 wants to merge 1 commits into bitcoin:master from johnlow95:patch-2 changing 1 files +1 −1

johnlow95 commented at 6:49 PM on August 2, 2018: contributor

No description provided.
Docs: Improve "of" grammar 081f5b4e2b
Empact commented at 6:51 PM on August 2, 2018: member

ACK 081f5b4
johnlow95 commented at 7:01 PM on August 2, 2018: contributor

do i need to add that also?
johnlow95 renamed this:
~~Docs: Improve "of" grammar~~
ACK 081f5b4 - Docs: Improve "of" grammar
on Aug 2, 2018
laanwj commented at 7:03 PM on August 2, 2018: member

I'm confused now
johnlow95 commented at 7:03 PM on August 2, 2018: contributor

confuse on ?
Empact commented at 7:12 PM on August 2, 2018: member

The ACK 081f5b4 I added earlier was an explicit approval of that specific change. You can remove it from the title. https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review
johnlow95 renamed this:
~~ACK 081f5b4 - Docs: Improve "of" grammar~~
Docs: Improve "of" grammar
on Aug 2, 2018
johnlow95 commented at 7:14 PM on August 2, 2018: contributor

oh, sorry for that
johnlow95 commented at 7:41 PM on August 2, 2018: contributor

so now i just wait for the PR to be approve and merge?
Empact commented at 8:01 PM on August 2, 2018: member

Yeah now other people will review and merge it if they see fit.
fanquake added the label Docs on Aug 2, 2018
johnlow95 commented at 1:54 AM on August 3, 2018: contributor

anywhere i can get someone to commit it now? I need it for my assignment
fanquake renamed this:
~~Docs: Improve "of" grammar~~
docs: fix typo in translation_process.md
on Aug 3, 2018
fanquake commented at 5:17 AM on August 3, 2018: member

trivial ACK 081f5b4
practicalswift commented at 7:59 AM on August 3, 2018: contributor

@johnlow95 Please remove the "of" in commit description. The "of" is confusing. The commit text should reflect the change your doing :-)

utACK 081f5b4e2baed28ffa3bf6ce11e0aec7156038c2 modulo correct commit description
fanquake added this to the "Mergeable" column in a project

laanwj commented at 2:21 PM on August 7, 2018: member

i'm just going to merge this, feel that having such a large discussion as this about a one-line doc change is besides the point—but yes next time please put some work in making a relevant and understandable commit message! utACK 081f5b4e2baed28ffa3bf6ce11e0aec7156038c2
laanwj merged this on Aug 7, 2018
laanwj closed this on Aug 7, 2018
laanwj referenced this in commit 7c82e40e76 on Aug 7, 2018
fanquake removed this from the "Mergeable" column in a project

fanquake locked this on Aug 8, 2018

Contributors

Labels