rpc: Use pushKV in some new PSBT RPCs #13927

pull domob1812 wants to merge 1 commits into bitcoin:master from domob1812:pushkv changing 2 files +5 −5

domob1812 commented at 5:03 PM on August 9, 2018: contributor

Most of the code uses UniValue::pushKV where appropriate, but some new RPC code related to PSBTs did not. This fixes those places - after this change, there are no remaining source files I could find that contain push_back(Pair(.

Use pushKV in some new PSBT RPCs.

Most of the code uses UniValue::pushKV where appropriate, but some new
RPC code related to PSBTs did not.

227d27e70c

achow101 commented at 6:29 PM on August 9, 2018: member

utACK 227d27e70c1b41ee88885d72bcf48448aa5a57a9
fanquake added the label Refactoring on Aug 10, 2018
fanquake commented at 12:55 AM on August 10, 2018: member

utACK 227d27e
fanquake renamed this:
~~trivial: Use pushKV in some new PSBT RPCs~~
rpc: Use pushKV in some new PSBT RPCs
on Aug 10, 2018
instagibbs commented at 4:27 PM on August 10, 2018: member

utACK https://github.com/bitcoin/bitcoin/pull/13927/commits/227d27e70c1b41ee88885d72bcf48448aa5a57a9

I see no more instances of old style
Empact commented at 9:55 PM on August 10, 2018: member

utACK 227d27e
sipa commented at 10:33 PM on August 10, 2018: member

utACK 227d27e70c1b41ee88885d72bcf48448aa5a57a9
MarcoFalke merged this on Aug 11, 2018
MarcoFalke closed this on Aug 11, 2018
MarcoFalke referenced this in commit bced8ea71a on Aug 11, 2018
jgarzik commented at 1:47 AM on August 11, 2018: contributor

posthumous utACK, push_back(Pair()) is deprecated
domob1812 deleted the branch on Aug 11, 2018
jnewbery commented at 2:25 PM on August 23, 2018: member

Reviewers for this, please review https://github.com/bitcoin-core/univalue/pull/11 so push_back(Pair()) doesn't get reintroduced to the codebase again.
DrahtBot locked this on Sep 8, 2021

Contributors

Labels