p2p: Remove dead code for nVersion=10300 #14025

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1808-netProc10300 changing 2 files +6 −20

MarcoFalke commented at 1:24 PM on August 22, 2018: member

This code is undocumented and confusing as well as dead, since peers with a version that old are disconnected immediately.
p2p: Remove dead code for nVersion=10300 fa5099ceb7
MarcoFalke added the label P2P on Aug 22, 2018
laanwj commented at 1:30 PM on August 22, 2018: member

utACK fa5099ceb757c9d56fa54a08d0441750df6c8869
scravy approved
scravy commented at 3:04 PM on August 22, 2018: contributor

<3
domob1812 approved
domob1812 commented at 4:46 PM on August 22, 2018: contributor

utACK fa5099ceb757c9d56fa54a08d0441750df6c8869.
Empact commented at 12:01 AM on August 23, 2018: member

utACK fa5099c MIN_PEER_PROTO_VERSION is 31800
fanquake commented at 12:18 AM on August 23, 2018: member

utACK fa5099c Looks like the final place in the code checking for that version is in walletdb: https://github.com/bitcoin/bitcoin/blob/0738b88fe0b6c840e3cefa810c2b6de6c8b32ed0/src/wallet/walletdb.cpp#L473
practicalswift commented at 8:09 AM on August 23, 2018: contributor

utACK fa5099ceb757c9d56fa54a08d0441750df6c8869
jnewbery commented at 1:50 PM on August 23, 2018: member

utACK fa5099ceb757c9d56fa54a08d0441750df6c8869

If you felt like it you could also remove a bunch of additional code from the msg_version class in test_framework/messages.py since the test framework won't work for anything older than a release or two ago. You could remove the if self.nVersion >= 106 and if self.nVersion >= 209: conditionals.
qa: Remove unused deserialization code in msg_version fa74d3d720
MarcoFalke force-pushed on Aug 23, 2018
jnewbery commented at 2:07 PM on August 23, 2018: member

utACK fa74d3d720f72c5f1184ca3e03b0c14a2bc06ed5.

We could also assert that the version is greater than MIN_PEER_PROTO_VERSION in the desererialize method of msg_version, but maybe that's overkill.
MarcoFalke merged this on Aug 23, 2018
MarcoFalke closed this on Aug 23, 2018
MarcoFalke referenced this in commit 5b52aa6858 on Aug 23, 2018
MarcoFalke deleted the branch on Aug 23, 2018
markblundeberg referenced this in commit f2206f5e56 on Nov 19, 2019
PastaPastaPasta referenced this in commit 68b1927446 on Apr 16, 2020
PastaPastaPasta referenced this in commit 1bca463247 on Apr 16, 2020
PastaPastaPasta referenced this in commit e59eecb977 on Apr 19, 2020
PastaPastaPasta referenced this in commit 80e64f54cb on Apr 20, 2020
PastaPastaPasta referenced this in commit aaa2373496 on May 10, 2020
PastaPastaPasta referenced this in commit dcb27c84c2 on May 12, 2020
PastaPastaPasta referenced this in commit 2fa446fde3 on Jun 9, 2020
PastaPastaPasta referenced this in commit f5b3661be6 on Jun 9, 2020
PastaPastaPasta referenced this in commit e424ac9d0e on Jun 10, 2020
PastaPastaPasta referenced this in commit 0e34bac97c on Jun 11, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels