Minor style enhancement in documentation #14091

pull fedsten wants to merge 2 commits into bitcoin:master from fedsten:master changing 118 files +287 −287
  1. fedsten commented at 10:50 am on August 28, 2018: none
    It is considered a best practice to avoid noun+verb contractions in technical documentation as it makes it easier to read, especially for non native English speakers. As a reference: https://developers.google.com/style/contractions
  2. laanwj added the label Docs on Aug 28, 2018
  3. practicalswift commented at 8:12 pm on August 28, 2018: contributor
    @fedsten Is this change exhaustive throughout the documentation? git grep might help you find similar cases :-)
  4. randolf approved
  5. DrahtBot commented at 12:15 pm on August 29, 2018: member
    • #14119 (qa: Read reject reasons from debug log, not p2p messages by MarcoFalke)
    • #14054 (p2p: Disable BIP 61 by default by MarcoFalke)
    • #14045 (refactor: Fix the chainparamsbase -> util circular dependency by Empact)
    • #13922 (Lower default relay fees by ajtowns)
    • #13868 (Remove unused fScriptChecks parameter from CheckInputs by Empact)
    • #13864 (validation: Document where we are intentionally ignoring bool return values from validation related functions by practicalswift)
    • #13804 (Transaction Pool Layer by MarcoFalke)
    • #13766 (Prefer initialization to assignment in constructors. Prefer in-class initializers to member initializers in constructors for constant initializers. by practicalswift)
    • #13582 (Extract AppInitLoadBlockIndex from AppInitMain by Empact)
    • #13525 (Report reason inputs are nonstandard from AreInputsStandard by Empact)
    • #13307 (Replace coin selection fallback strategy with Single Random Draw by achow101)
    • #13249 (Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. by practicalswift)
    • #13128 (policy: Add Clang thread safety annotations for variables guarded by cs_feeEstimator by practicalswift)
    • #10973 (Refactor: separate wallet from node by ryanofsky)
    • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. ken2812221 commented at 9:36 pm on August 30, 2018: contributor
    Please squash these changes into single commit.
  7. laanwj renamed this:
    Minor style enhacement in documentation
    Minor style enhancement in documentation
    on Aug 31, 2018
  8. DrahtBot added the label Needs rebase on Aug 31, 2018
  9. Update fuzzing.md 3bb6f34f66
  10. style enhancement in docs ec49b56c58
  11. fedsten force-pushed on Aug 31, 2018
  12. fedsten commented at 8:19 pm on August 31, 2018: none
    I updated the pull request and made sure the change is exhaustive throughout the documentation
  13. DrahtBot removed the label Needs rebase on Aug 31, 2018
  14. fanquake commented at 8:27 am on September 2, 2018: member

    I’ve looked through all the changes here, and they are basically just changing: there’s -> there is they’ll -> they will they’ve -> they have you’re -> you are you’ve -> you have we’ll -> we will we’re -> we are

    across the entire repository. Given this isn’t actually fixing anything, it has a large number of conflicts and it fails the linter because it’s modifying subtrees, I’m just going to close this sorry.

    edit: This type of change is normally best suited right at the end of a merge window, when conflicts and other issues aren’t a problem.

  15. fanquake closed this on Sep 2, 2018

  16. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me