Trivial: gitignore contents of db4 folder #14314

murtyjones commented at 9:04 PM on September 24, 2018: contributor

A lot of stuff is generated by running ./contrib/install_db4.sh .. I had to ignore it to avoid committing to my repo and I'm sure many others must do the same.

lcov: filter /usr/lib/ from coverage reports fa6b30c40b

Make fs::path::string() always return utf-8 string 2c3eade704

tests: write the notification to different files to avoid race condition 67654b6405

gitignore contents of db4 folder d3881b6f43

AppVeyor: Move AppVeyor YAML to dot-file-style YAML

AppVeyor supports dot-file-style YAML named .appveyor.yml as is. This
helps keep the root of the repository clean(ish) and readable by having
the CI files as dot-files.

ff40357da1

fanquake commented at 4:26 AM on September 25, 2018: member

utACK d3881b6

in .gitignore:121 in d3881b6f43 outdated

 115 | @@ -116,3 +116,6 @@ test/cache/*
 116 |  
 117 |  libbitcoinconsensus.pc
 118 |  contrib/devtools/split-debug.sh
 119 | +
 120 | +# Output from running db4 installation
 121 | +db4/*

practicalswift commented at 4:50 AM on September 25, 2018:

Nit: db4/

murtyjones commented at 10:18 AM on September 25, 2018:

Done

practicalswift commented at 4:50 AM on September 25, 2018: contributor

utACK d3881b6f435daace615de1dfe56d4aade882b4d6 modulo nit

removes unneeded asterisk e445d14f97

gitignores .idea 879dd23709

murtyjones commented at 10:19 AM on September 25, 2018: contributor

I slipped in another one for mac users of Intellij – the .idea folder.

scravy commented at 10:33 AM on September 25, 2018: contributor

I slipped in another one for mac users of Intellij – the .idea folder.

Please don't. Read the developer notes: https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#ignoring-ideeditor-files

In closed-source environments in which everyone uses the same IDE it is common to add temporary files it produces to the project-wide .gitignore file.

However, in open source software such as Bitcoin Core, where everyone uses their own editors/IDE/tools, it is less common. Only you know what files your editor produces and this may change from version to version. The canonical way to do this is thus to create your local gitignore.

.idea 8374b85351

murtyjones commented at 3:41 PM on September 25, 2018: contributor

OK, it's removed.

Merge branch 'master' of https://github.com/bitcoin/bitcoin 6b27f736ef

Merge #14275: tests: Write the notification message to different files to avoid race condition in feature_notifications.py

67654b6405 tests: write the notification to different files to avoid race condition (Chun Kuan Lee)

Pull request description:

  This PR change the behavior that `feature_notifications.py` would write to different files instead of writing to  the same file to avoid race condition.

Tree-SHA512: 78406167cc6a3f570134b0ee76d2be1440bc1498cd7b1be72fae16d0ab86950e26ef3bf6008796016e5418231400c6492f0e062909dd882646541ecb7a70fb30

bb8c9b3f74

Merge #14306: AppVeyor: Move AppVeyor YAML to dot-file-style YAML

ff40357da1 AppVeyor: Move AppVeyor YAML to dot-file-style YAML (Mitchell Cash)

Pull request description:

  AppVeyor supports dot-file-style YAML named `.appveyor.yml` as is. This helps keep the root of the repository clean(ish) and readable by having the CI files as dot-files.

  Source: https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming

Tree-SHA512: da2a78aff775e5e146f0784b1a6617d0371a5821da8a53be9e4aa57409cb16360f43d0afa5745f81f776599950cab4219a5d7ee7247d42e25861963ea487db66

9f94483b7a

Merge #14281: lcov: filter /usr/lib/ from coverage reports

fa6b30c40b lcov: filter /usr/lib/ from coverage reports (MarcoFalke)

Pull request description:

  This folder was included for me on ubuntu trusty and bionic when creating coverage reports.

  Can be tested by passing `--enable-lcov` +optional `--enable-lcov-branch-coverage` to `./configure`

  Then `make -j 4 && make cov`, which will generate the report in html.

  See https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#compiling-for-test-coverage

Tree-SHA512: 722deda8bca0d6d63e10dd55848ab72318d5cdbd56ab7ea19a1d1ca7285989bd3f0ccc72c3001aad326e1ce5b008e0a183bb5f05f2225d80ec68377c9434293a

8efd87455b

Merge #13877: utils: Make fs::path::string() always return utf-8 string on Windows

2c3eade704 Make fs::path::string() always return utf-8 string (Chun Kuan Lee)

Pull request description:

  Imbue `fs::path` with `std::codecvt_utf8_utf16` at `SetupEnvironment()`, so that default string encoding will be utf-8 inside `fs::path`.

Tree-SHA512: 0cb59464d777278decbf24771fc5ff0cb2caa7bc2fe8ee5cd36c97a2324873a3caad131f08f050393b488316ee7f4ab0b28b7fa4699e41839f8e51b9867d5118

cc7258bdfb

Merge branch 'master' of https://github.com/murtyjones/bitcoin 2872af10dc

DrahtBot commented at 4:25 AM on September 28, 2018: member

Coverage	Change (pull 14314)	Reference (master)
Lines	+0.0088 %	87.0361 %
Functions	+0.0000 %	84.1130 %
Branches	-0.0038 %	51.5451 %

fanquake commented at 4:27 AM on October 19, 2018: member

Included in #14515.

fanquake closed this on Oct 19, 2018

practicalswift referenced this in commit 76ae7a1ac9 on Nov 5, 2018

Munkybooty referenced this in commit 8497b930ca on Jul 22, 2021

Munkybooty referenced this in commit 045c6ee24a on Jul 23, 2021

Munkybooty referenced this in commit f24b3590ca on Jul 23, 2021

Munkybooty referenced this in commit bbe949e427 on Jul 23, 2021

Munkybooty referenced this in commit afa1bc97ef on Jul 23, 2021

Munkybooty referenced this in commit eb500edfab on Jul 26, 2021

Munkybooty referenced this in commit 3ec6506cf1 on Jul 27, 2021

DrahtBot locked this on Sep 8, 2021