I think bitcoin-tx.exe should be packed into the Windows installer.
build: Add bitcoin-tx.exe into Windows installer #14698
pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:win-bitcoin-tx changing 2 files +6 −0-
ken2812221 commented at 2:26 PM on November 9, 2018: contributor
-
build: Add bitcoin-tx.exe into Windows installer 5c5902acc5
- fanquake added the label Windows on Nov 9, 2018
- fanquake added the label Build system on Nov 9, 2018
- MarcoFalke added the label Needs gitian build on Nov 9, 2018
-
MarcoFalke commented at 3:08 PM on November 9, 2018: member
utACK 5c5902acc515c8f46ad73222cd57a29c4c13b92c. Also, we are running the util tests in appveyor (on windows), so bitcoin-tx should have basic test coverage.
-
DrahtBot commented at 3:30 AM on November 10, 2018: member
<!--a722867cd34abeea1fadc8d60700f111-->
Gitian builds for commit cbf00939b5e813937fb21466aa3e229ca81cb6ba (master):
03de9c4e0db99546880b65d8ee0fc79d...bitcoin-0.17.99-aarch64-linux-gnu-debug.tar.gz7af1f2f1d136e77e6f66e1b5c835883f...bitcoin-0.17.99-aarch64-linux-gnu.tar.gz4bbe5efbc1ce10923842064acf0049d5...bitcoin-0.17.99-arm-linux-gnueabihf-debug.tar.gz90f5b87c8024326da340e1d047b74d53...bitcoin-0.17.99-arm-linux-gnueabihf.tar.gzbb1146de8b266f0219609f4bea1a83b6...bitcoin-0.17.99-i686-pc-linux-gnu-debug.tar.gze0df04f2434300d247393b934c1dc72a...bitcoin-0.17.99-i686-pc-linux-gnu.tar.gzb8af39344ef7921fdd0652630ea42ff2...bitcoin-0.17.99-osx-unsigned.dmgbcf05778936b0ea27158d9314e9a2f5f...bitcoin-0.17.99-osx64.tar.gz8c96f213dd5f5942f5d73e7157f1517d...bitcoin-0.17.99-riscv64-linux-gnu-debug.tar.gz7c0a3a8a7b197cd66a6560344e305e4b...bitcoin-0.17.99-riscv64-linux-gnu.tar.gz509e055b986d9b4d4b71f4cdbea276d0...bitcoin-0.17.99-win32-debug.zipbe3df67299583f6c810c784a995299a0...bitcoin-0.17.99-win32-setup-unsigned.exe0e90c8b0af1d2d2385459c894d7e93fd...bitcoin-0.17.99-win32.zipa6be69167e1a79e84ac4926aed93255d...bitcoin-0.17.99-win64-debug.zipe7861849b5158549c31f3283b78b0b76...bitcoin-0.17.99-win64-setup-unsigned.exe647612752f3a19ce177a0f5c9edee8d2...bitcoin-0.17.99-win64.zip909330723b61413c178ac291b42985b4...bitcoin-0.17.99-x86_64-linux-gnu-debug.tar.gzb761461a2fb68ed6c0f04ec14c5ecccc...bitcoin-0.17.99-x86_64-linux-gnu.tar.gz63a34c10fc9a55ebde302d2c0f6eae0d...bitcoin-0.17.99.tar.gzaa5caaec57d1adbca7fdc26fd5efcbd3...bitcoin-linux-0.18-res.yml48197e3e8d7bfa97e05a6acb6b9e747f...bitcoin-linux-build.log0fbd023e6b56584025f93c19ee7aa65e...bitcoin-osx-0.18-res.yml518e7f5d508130854e14154eed87a446...bitcoin-osx-build.logc2d4a565f5af557396654c6b424ce3e7...bitcoin-win-0.18-res.yml7614daf7b130ad51bb5c3c18807a18ea...bitcoin-win-build.log
Gitian builds for commit 233aca186fe95af66e6d5ffd2f50fae358c0d1d6 (master and this pull):
0aab25d989da1503c32f8d82e1fb80bd...bitcoin-0.17.99-aarch64-linux-gnu-debug.tar.gz90240e49afb856ace1c6c4232f28d99c...bitcoin-0.17.99-aarch64-linux-gnu.tar.gz1d59ec89c8a590c0f3d5c6ee6102cf1d...bitcoin-0.17.99-arm-linux-gnueabihf-debug.tar.gz8fcd629066906af4a0e7aa374d74f8ed...bitcoin-0.17.99-arm-linux-gnueabihf.tar.gz152261531d207517eb1900fdeddb03c0...bitcoin-0.17.99-i686-pc-linux-gnu-debug.tar.gzc44e685b879971410675489a82e561fc...bitcoin-0.17.99-i686-pc-linux-gnu.tar.gz4b6d2f7b9e54223ea7450852b510a187...bitcoin-0.17.99-osx-unsigned.dmga82bca27ca802158e173fb61d443c48f...bitcoin-0.17.99-osx64.tar.gzc97d3b694427dd32aa42a462318d9f0d...bitcoin-0.17.99-riscv64-linux-gnu-debug.tar.gz6930614e84dd245ad6c39a21209c4c1a...bitcoin-0.17.99-riscv64-linux-gnu.tar.gzda5fc796181f0ddd9af7659057919f66...bitcoin-0.17.99-win32-debug.zipfbc4ef451f37995162a14f172822be96...bitcoin-0.17.99-win32-setup-unsigned.exe993cec26c5df4bf52dd4a39d0bc3a89d...bitcoin-0.17.99-win32.zip6a8976a5cbba7ae21458dc97fe529e01...bitcoin-0.17.99-win64-debug.zip8c2cb0dc138e80e694761ec37a0da3a6...bitcoin-0.17.99-win64-setup-unsigned.exe3183c65183b291673e3fc208e8492e1c...bitcoin-0.17.99-win64.zipe1a04a119e3c0f012c430cdc454b97e1...bitcoin-0.17.99-x86_64-linux-gnu-debug.tar.gz79d2ba2a2637ab46da17db31df22ff71...bitcoin-0.17.99-x86_64-linux-gnu.tar.gz5d58288dd93d1b7fa88c00d07a9b2132...bitcoin-0.17.99.tar.gz425305d930303b30d4d958627e14d9f1...bitcoin-linux-0.18-res.ymlb8ba0d6dfb956b207a010f6c68629eb4...bitcoin-linux-build.log14eb841cad239a428ba785030640cec4...bitcoin-osx-0.18-res.yml16d9e936a9eadc4ad44b739c974c8974...bitcoin-osx-build.logd30561bc86c36ba52363814dfc4c13a8...bitcoin-win-0.18-res.ymlea8c9f2e132b18bceec09d04a7248c29...bitcoin-win-build.log
- DrahtBot removed the label Needs gitian build on Nov 10, 2018
-
laanwj commented at 11:54 AM on November 10, 2018: member
I'm surprised that this has been the case for so long and we only notice now.
utACK in any case
-
hebasto commented at 9:13 PM on November 10, 2018: member
utACK 5c5902acc515c8f46ad73222cd57a29c4c13b92c
-
fanquake commented at 5:32 AM on November 11, 2018: member
utACK 5c5902a
-
jonasschnelli commented at 10:53 AM on November 11, 2018: contributor
utACK 5c5902ac
-
murrayn commented at 9:38 AM on November 14, 2018: contributor
-
meshcollider commented at 11:22 AM on November 14, 2018: contributor
Tested the 64 bit installer from the gitian build above
ACK https://github.com/bitcoin/bitcoin/pull/14698/commits/5c5902acc515c8f46ad73222cd57a29c4c13b92c
- laanwj merged this on Nov 14, 2018
- laanwj closed this on Nov 14, 2018
- laanwj referenced this in commit 33cd94279c on Nov 14, 2018
- ken2812221 deleted the branch on Nov 14, 2018
-
gmaxwell commented at 12:36 AM on November 20, 2018: contributor
Should this be tagged for backport?
- MarcoFalke referenced this in commit a7a5c21ec7 on Nov 20, 2018
- MarcoFalke referenced this in commit ec71f06a8d on Nov 28, 2018
- PastaPastaPasta referenced this in commit 1d59c2cc9b on Jun 27, 2021
- PastaPastaPasta referenced this in commit fef8950965 on Jun 28, 2021
- PastaPastaPasta referenced this in commit 9f079ceb7d on Jun 29, 2021
- PastaPastaPasta referenced this in commit 8ac09ebdc5 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 2cec231b19 on Jul 1, 2021
- PastaPastaPasta referenced this in commit fd4b647787 on Jul 1, 2021
- UdjinM6 referenced this in commit a5aee198cd on Jul 5, 2021
- MarcoFalke locked this on Sep 8, 2021