Scripts: Fix detection of copyright holders #14785

pull cornelius wants to merge 1 commits into bitcoin:master from cornelius:copyright-header changing 1 files +15 −15

cornelius commented at 2:01 PM on November 22, 2018: contributor
Fix copyright holder detection so that copyright_header.py report creates a clean and accurate report:
- Fix list of copyright holders in the code
- Also detect copyrights which have a comma after the date
- Exclude directories which are git subtrees
fanquake added the label Scripts and tools on Nov 22, 2018
scravy commented at 2:12 PM on November 22, 2018: contributor

utACK 89104ef98f882c24695043b74feec2b9d0d8496f

very nice change, the EXCLUDE_DIRS one.
scravy approved
cornelius commented at 3:56 PM on November 22, 2018: contributor

The failing test doesn't seem to be related to the code changes. It also does work locally.
MarcoFalke commented at 4:26 PM on November 22, 2018: member

utACK 89104ef98f882c24695043b74feec2b9d0d8496f
fanquake commented at 4:17 AM on November 23, 2018: member

utACK 89104ef
Empact commented at 4:51 AM on November 23, 2018: member

utACK 89104ef
in contrib/devtools/copyright_header.py:41 in 89104ef98f outdated
```
  50 | +
  51 |  INCLUDE = ['*.h', '*.cpp', '*.cc', '*.c', '*.py']
  52 |  INCLUDE_COMPILED = re.compile('|'.join([fnmatch.translate(m) for m in INCLUDE]))
  53 |  
  54 |  def applies_to_file(filename):
  55 | +    for dir in EXCLUDE_DIRS:
```
practicalswift commented at 6:13 AM on November 23, 2018:

Use another variable name to avoid redefining the built-in function dir :-)

cornelius commented at 10:05 AM on November 23, 2018:

Good point. Fixing it. Thanks.
laanwj commented at 10:02 AM on November 23, 2018: member

utACK, but yes makes sense to address @practicalswift 's comment wrt overwriting internal functions.
practicalswift commented at 10:19 AM on November 23, 2018: contributor

utACK da9c379c4fafd5e39566a2014777513e87f5fb39
laanwj commented at 10:33 AM on November 23, 2018: member

utACK after squashing commits

Fix detection of copyright holders

* There is a copyright notice in `src/crypto/sha256_sse4.cpp` in the
  middle of the file which contains a comma before the copyright
  holder name. Correctly detect this so it's added to the report.
* Add missing copyright holders so that `copyright_header.py report`
  doesn't show any unexpected copyright holder names anymore.
* Exclude files from git subtrees because they are maintained at the
  original source.

af9a9918b2

cornelius force-pushed on Nov 23, 2018
cornelius commented at 4:26 PM on November 23, 2018: contributor

Squashed commits
MarcoFalke commented at 7:01 PM on November 23, 2018: member

Someone could probably bump the headers at this time of the year...
MarcoFalke merged this on Nov 23, 2018
MarcoFalke closed this on Nov 23, 2018
MarcoFalke referenced this in commit a7dc03223e on Nov 23, 2018
cornelius referenced this in commit a05f0b4029 on Nov 27, 2018
deadalnix referenced this in commit 77d8466cfa on Feb 1, 2021
kittywhiskers referenced this in commit e530cdb58f on Jul 4, 2021
kittywhiskers referenced this in commit c7ad1cf822 on Jul 9, 2021
kittywhiskers referenced this in commit a2f4e9c74a on Jul 11, 2021
kittywhiskers referenced this in commit dc01a872cd on Jul 11, 2021
PastaPastaPasta referenced this in commit f1f32364f6 on Jul 13, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels