One Travis instance should run minimum supported QT version #14983

1. 
   Sjors commented at 2:47 pm on December 17, 2018: member

   @jonasschnelli wrote in #14979:

   #14573 broke < Qt5.6 compatibility due to calling the lambda version of addAction that was added in Qt5.6.

   We currently support QT >=5.2, but hardly anyone tests with that. If we make one of the Travis machines use it, we should have a better change of catching this.

   See also discussion about minimum QT version in #13478

2. fanquake added the label Tests on Dec 17, 2018
3. fanquake added the label GUI on Dec 17, 2018
4. 
   promag commented at 2:55 pm on December 17, 2018: member

   The problem is that 5.2 is only available in trusty repository, bionic has 5.9. I’m not sure if adding an older repository is a good practice.
5. 
   Sjors commented at 3:06 pm on December 17, 2018: member

   That could be a good reason to bump the minimum to whatever is available on Ubuntu Xenial (16.04), since we do have one such instance.
6. 
   MarcoFalke commented at 3:10 pm on December 17, 2018: member

   We already build on xenial, but the travis error wasn’t reported
7. 
   Sjors commented at 4:01 pm on December 17, 2018: member

   @marcofalke I mean we should run the oldest possible version of QT 5.* on the Xenial machine, and then increase the minimum supported version from 5.2 to that.
8. 
   MarcoFalke commented at 4:04 pm on December 17, 2018: member

   Again, I am not aware on how to conveniently install a version different from the ubuntu flavoured default that comes in the package manager.
9. 
   MarcoFalke commented at 4:05 pm on December 17, 2018: member

   Oh, you said to bump the minimum to 5.5, which comes with xenial
10. 
    promag commented at 4:07 pm on December 17, 2018: member

    Related to #13478 (comment).
11. 
    hebasto commented at 4:24 pm on December 17, 2018: member

    … bump the minimum to 5.5, which comes with xenial

    Agree.

12. 
    luke-jr commented at 5:08 pm on December 17, 2018: member

    @Sjors Minimum versions need to be what is at least available with the most recent stable release of major distros… Ubuntu-only is not an acceptable outcome.

    Adding old packages should be fairly safe, so long as they’re not needed for running other packaged tools.

    (This bug should probably apply to more dependencies than just Qt.)

    Arch: Qt 5.12 Debian: Qt 5.7 Gentoo: Qt 5.11 RHEL: Qt 5.9 Ubuntu: Qt 5.9

13. 
    MarcoFalke commented at 6:04 pm on December 17, 2018: member

    Minimum versions need to be what is at least available with the most recent stable release of major distros

    Would be nice to add this to doc/dependencies.md and also add what “major distros” are. See also https://github.com/fanquake/core-review/blob/master/operating-systems.md by @fanquake

14. 
    luke-jr commented at 6:32 pm on December 17, 2018: member

    Might be good to use a LTS version for the minimum too - which would indicate Qt 5.6
15. 
    Empact commented at 11:21 pm on December 17, 2018: member

    I’m working on CI for ubuntu 14.04, which runs QT 5.2.1. Here’s the current latest CI run: https://travis-ci.org/Empact/bitcoin/jobs/469269171
16. 
    Empact commented at 11:26 pm on December 17, 2018: member

    We already build on xenial, but the travis error wasn’t reported

    As I recall, the build failed, but there was one or more other incidental build failures at the time which contributed to it being overlooked, e.g. #14969.

17. 
    jonasschnelli commented at 6:00 am on December 18, 2018: contributor

    Setting Qt5.6 as minimum requirement would be acceptable I think. Though I don’t see a pressing need (except the missing CI)
18. MarcoFalke closed this on Feb 1, 2019

    ---

19. MarcoFalke referenced this in commit 2c0867a181 on Feb 1, 2019
20. MarcoFalke locked this on Dec 16, 2021
21. vijaydasmp referenced this in commit 34e8b3e2cd on Dec 31, 2021
22. vijaydasmp referenced this in commit 72208e81cd on Jan 25, 2022
23. vijaydasmp referenced this in commit 67c44a26d0 on Mar 15, 2022
24. vijaydasmp referenced this in commit 8126e6d115 on Mar 15, 2022
25. vijaydasmp referenced this in commit c6e7339bab on Mar 27, 2022
26. vijaydasmp referenced this in commit dcb7e3d1c2 on Mar 27, 2022
27. vijaydasmp referenced this in commit 64ac0f389b on Mar 30, 2022

Contributors
Sjors promag MarcoFalke hebasto luke-jr Empact jonasschnelli

Labels
GUI Tests