Build: add names to Travis jobs #15020

gkrizek commented at 6:51 PM on December 21, 2018: contributor

This adds the name field to all the TravisCI jobs. This will make it more obvious in the Travis UI what job is failing or passing.

in .travis.yml:54 in c803a92262 outdated

  52 | @@ -52,6 +53,7 @@ jobs:
  53 |          - set -o errexit; source .travis/lint_06_script.sh
  54 |  # ARM

scravy commented at 7:06 PM on December 21, 2018:

I guess these comments could then be removed

gkrizek commented at 7:18 PM on December 21, 2018:

I left them because some contain information that I didn't want to put in the job name. Like the Xenial build for example. I supposed we could remove the names from the comments and leave only the extra details when needed.

gkrizek commented at 9:03 PM on December 21, 2018:

I just pushed a commit that removes these comments and moves the needed comments to beside the job name.

in .travis.yml:85 in c803a92262 outdated

  80 |          PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64"
  81 |          GOAL="deploy"
  82 |          BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests"
  83 |  # 32-bit + dash
  84 |      - stage: test
  85 | +      name: '32-bit + dash'

scravy commented at 7:07 PM on December 21, 2018:

I for one value very much to be able to see the build environment variables when looking at the travis overview page for the build. This is lost now as one sees only this identifier. I like to see the environment variables to understand whether the particular build runs functional tests and/or unit tests or not. Maybe this information should be added to the name.

gkrizek commented at 7:22 PM on December 21, 2018:

I agree! I was sad to see that Travis removed the environment variables from the UI when you add a name. You can see the environment variables still if you go into a build job. Nonetheless, I can certainly add a test type to the job name if we would like.

scravy commented at 7:10 PM on December 21, 2018: contributor

Documentation for the feature: https://docs.travis-ci.com/user/build-stages/#naming-your-jobs-within-build-stages

fanquake added the label Tests on Dec 21, 2018

DrahtBot commented at 12:51 PM on December 24, 2018: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#14998 ([WIP] Run CI against ubuntu 14.04 by Empact)
#14505 (Add linter to make sure single parameter constructors are marked explicit (C++11) by default by practicalswift)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Empact commented at 12:30 AM on December 25, 2018: member

Concept ACK

gkrizek force-pushed on Dec 26, 2018

gkrizek commented at 9:53 PM on December 26, 2018: contributor

As previously commented, when you add a name to your jobs the Travis UI removes the environment variables from the build when in the list view. (They still show up when you view an individual build's page). I think having a build name is more valuable in the list view than the variables. We can always add some sort of 'tag' to the job name if we feel that's needed.

fanquake commented at 4:56 AM on December 31, 2018: member

Here's the current Travis setup vs this PR: Current: current #15020 (30922a7): build names

If anything, I think we could add more build related information to the "name", if we go down that route.

fanquake requested review from MarcoFalke on Dec 31, 2018

Empact commented at 7:22 PM on December 31, 2018: member

Here's an example where a new "disable bip 70" build was added - I challenge you to quickly identify which build it is: https://travis-ci.org/bitcoin/bitcoin/builds/473735618?utm_source=github_status&utm_medium=notification #15063

It could be helpful to describe the build more fully, e.g. "no depends, only system libs, sanitizers: thread (TSan)" is relevant IMO. Also possibly: GOAL, osx version.

gkrizek force-pushed on Dec 31, 2018

gkrizek commented at 10:01 PM on December 31, 2018: contributor

@Empact That's why I thought this PR could be helpful. Same for someone new looking at the project. Very hard to tell what's going on in the current state.

I just pushed a commit that adds more details to the job names as it seems like more are in agreement that it would be helpful.

in .travis.yml:68 in 6b486c2621 outdated

  62 | @@ -61,65 +63,74 @@ jobs:
  63 |          # -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1"
  64 |          # This could be removed once the ABI change warning does not show up by default
  65 |          BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports CXXFLAGS=-Wno-psabi"
  66 | -# Win32
  67 | +
  68 |      - stage: test
  69 | +      name: 'Win32  [GOAL: deploy]'

fanquake commented at 3:38 AM on January 3, 2019:

Could add [no gui tests] to Win32 & Wind64.

in .travis.yml:103 in 6b486c2621 outdated

 103 |          GOAL="install"
 104 |          BITCOIN_CONFIG="--enable-zmq --with-gui=qt5 --enable-glibc-back-compat --enable-reduce-exports --enable-debug CXXFLAGS=\"-g0 -O2\""
 105 | -# x86_64 Linux (xenial, no depends, only system libs, sanitizers: thread (TSan))
 106 | +
 107 |      - stage: test
 108 | +      name: 'x86_64 Linux  [GOAL: install]  [xenial]  [no depends, only system libs, sanitizers: thread (TSan)]'

fanquake commented at 3:40 AM on January 3, 2019:

Can add [no wallet] to the last set of brackets here. See --disable-wallet.

in .travis.yml:133 in 6b486c2621 outdated

 136 |          GOAL="install"
 137 |          BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
 138 | -# Cross-Mac
 139 | +
 140 |      - stage: test
 141 | +      name: 'macOS 10.11  [GOAL: deploy]'

fanquake commented at 3:40 AM on January 3, 2019:

This should be macOS 10.10.

in .travis.yml:114 in 6b486c2621 outdated

 115 |          GOAL="install"
 116 |          BITCOIN_CONFIG="--enable-zmq --disable-wallet --with-gui=qt5 CPPFLAGS=-DDEBUG_LOCKORDER --with-sanitizers=thread --disable-hardening --disable-asm CC=clang CXX=clang++"
 117 | -# x86_64 Linux (no depends, only system libs, sanitizers: address/leak (ASan + LSan) + undefined (UBSan) + integer)
 118 | +
 119 |      - stage: test
 120 | +      name: 'x86_64 Linux  [GOAL: install]  [no depends, only system libs, sanitizers: address/leak (ASan + LSan) + undefined (UBSan) + integer]'

fanquake commented at 3:45 AM on January 3, 2019:

Could add [bionic] here and to the other Linux builds to make it explicit/obvious which OS is being used.

gkrizek force-pushed on Jan 3, 2019

gkrizek commented at 5:12 AM on January 3, 2019: contributor

@fanquake Thanks for the review! I've pushed a commit with your changes added.

fanquake commented at 6:48 AM on January 3, 2019: member

ACK 5af7d0b. I think this is ok now.

travis named jobs @scravy @Empact thoughts?

in .travis.yml:109 in 5af7d0b9ec outdated

 109 |        env: >-
 110 |          HOST=x86_64-unknown-linux-gnu
 111 |          DOCKER_NAME_TAG=ubuntu:16.04
 112 |          PACKAGES="clang llvm python3-zmq qtbase5-dev qttools5-dev-tools libssl-dev libevent-dev bsdmainutils libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev libdb5.3++-dev libminiupnpc-dev libzmq3-dev libprotobuf-dev protobuf-compiler libqrencode-dev"
 113 |          NO_DEPENDS=1
 114 | +        FUNCTIONAL_TESTS_CONFIG="--exclude feature_block.py,p2p_invalid_messages.py"

MarcoFalke commented at 10:44 AM on January 3, 2019:

Why?

laanwj commented at 1:12 PM on January 3, 2019:

looks like an accidental revert of fa05d52af475dc4109c09b70b17b22f5ffc6e6e6

gkrizek commented at 3:02 PM on January 3, 2019:

Ah, I think you are right. I'll fix that

gkrizek commented at 3:21 PM on January 3, 2019:

@MarcoFalke @laanwj I just pushed a new commit without this line. Sorry about that.

laanwj commented at 1:04 PM on January 3, 2019: member

Concept ACK

Add names to Travis jobs

This also removes job name comments from .travis.yml because they are no longer necessary

1db71d4a29

gkrizek force-pushed on Jan 3, 2019

MarcoFalke referenced this in commit 06fabfa287 on Jan 3, 2019

MarcoFalke merged this on Jan 3, 2019

MarcoFalke closed this on Jan 3, 2019

gkrizek deleted the branch on Jan 3, 2019

jnewbery commented at 8:36 PM on January 7, 2019: member

Great! I've been wanting this for a long time. utACK 1db71d4a29356b7c3e3ea3c806cff586148dcb65.

Munkybooty referenced this in commit ca9222018d on Aug 13, 2021

Munkybooty referenced this in commit 4dbedb9564 on Aug 15, 2021

Munkybooty referenced this in commit 81dbe1514a on Aug 17, 2021

Munkybooty referenced this in commit f15b20fca5 on Aug 20, 2021

Munkybooty referenced this in commit 1b93a7ea82 on Aug 21, 2021

Munkybooty referenced this in commit ad53b27a74 on Aug 23, 2021

Munkybooty referenced this in commit 52812e7707 on Aug 24, 2021

Munkybooty referenced this in commit ec871c1933 on Aug 24, 2021

MarcoFalke locked this on Dec 16, 2021