0.17: Backport for #15085 #15094

1. 
   benthecarman commented at 11:09 PM on January 3, 2019: contributor

   Changes the application name to Bitcoin-Qt-regtest when instead of Bitcoin-Qt-testnet

   Fixes #15079

2. fanquake added the label Backport on Jan 3, 2019
3. fanquake added this to the milestone 0.17.2 on Jan 3, 2019
4. 
   fanquake commented at 11:17 PM on January 3, 2019: member

   You'll need to wait for #15085 to be merged first. Then you can create a proper backport commit, (see this script for help) which has the correct Github-Pull, Rebased-From info in the commit body. See #15002 for an example.

5. 
   benthecarman commented at 11:19 PM on January 3, 2019: contributor

   Oh okay, thank you

6. benthecarman closed this on Jan 3, 2019

   ---

7. 
   promag commented at 11:22 PM on January 3, 2019: member

   You'll need to wait for #15085 to be merged first @fanquake didn't wait in #15002 :trollface:

8. 
   fanquake commented at 11:25 PM on January 3, 2019: member

   @benthecarman You can still use this PR though. You should be able to force push to the existing branch once 15085 is merged 👍.

9. fanquake reopened this on Jan 5, 2019

   ---

10. 
    fanquake commented at 1:03 PM on January 5, 2019: member

    @benthecarman Could you now turn this into a proper backporting commit?

11. benthecarman force-pushed on Jan 5, 2019
12. benthecarman force-pushed on Jan 5, 2019
13. 
    promag commented at 3:53 PM on January 5, 2019: member

    @benthecarman still not right.

14. 
    MarcoFalke commented at 3:54 PM on January 5, 2019: member

    There is a script to do that: https://github.com/bitcoin-core/bitcoin-maintainer-tools#backport

15. gui: Fix for Incorrect application name when passing -regtest

    Github-Pull: #15085
    Rebased-From: cc341adbbb7584d3110a5151baf1ba4053aa2ed1

    59dd855d2d
16. benthecarman force-pushed on Jan 5, 2019
17. fanquake approved
18. 
    fanquake commented at 4:57 PM on January 5, 2019: member

    utACK 59dd855

19. 
    laanwj commented at 1:38 PM on January 7, 2019: member

    I don't think this warrants a separate backport PR. I think it's better to group these small changes, and leave separate backport PR for difficult changes that are significantly different between branches.

    That said utACK 59dd855d2de77cd72a2b3190a825783ff3627e17 for this time.

20. laanwj merged this on Jan 7, 2019
21. laanwj closed this on Jan 7, 2019

    ---

22. laanwj referenced this in commit 0a0b2ea11f on Jan 7, 2019
23. DrahtBot locked this on Dec 16, 2021

Milestone
0.17.2