build_msvc: Fix the build problem in libbitcoin_server #15110

pull Mr-Leshiy wants to merge 1 commits into bitcoin:master from Mr-Leshiy:MrLeshiy_Fix_Build changing 1 files +0 −6

Mr-Leshiy commented at 4:20 PM on January 5, 2019: contributor

Fixes #15049

The reason of this problem is existance two similar lines in the libbitcoin_server.vcxproj file that appears after the executing the msvc-autogen.py script .

line 157

<ItemGroup> <ClCompile Include="..\..\src\rpc\net.cpp"> <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">$(IntDir)\netrpc.obj</ObjectFileName> <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">$(IntDir)\netrpc.obj</ObjectFileName> <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(IntDir)\netrpc.obj</ObjectFileName> <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|x64'">$(IntDir)\netrpc.obj</ObjectFileName> </ClCompile>

line 256

<ItemGroup> <ClCompile Include="..\..\src\rpc\net.cpp"> <ObjectFileName>$(IntDir)rpc_net.obj</ObjectFileName> </ClCompile>
Fix the build problem in libbitcoin_server c98f8866fe
fanquake added the label Windows on Jan 5, 2019
MarcoFalke renamed this:
~~Fix the build problem in libbitcoin_server~~
build_msvc: Fix the build problem in libbitcoin_server
on Jan 5, 2019
fanquake commented at 4:55 PM on January 5, 2019: member

tACK c98f886

Prior to this change, the libbitcoin_server "solution" is unusable: <img width="193" alt="screen shot 2019-01-06 at 12 48 56 am" src="https://user-images.githubusercontent.com/863730/50726848-91eea180-114d-11e9-8f3e-57298dc55433.png">

After applying c98f886 and regenerating the project files it works correctly: <img width="994" alt="vstudio" src="https://user-images.githubusercontent.com/863730/50726852-a2068100-114d-11e9-9b72-f80ea409e0c0.png">
practicalswift commented at 11:42 PM on January 5, 2019: contributor

@Mr-Leshiy Very nice first-time contribution! Welcome as a contributor! :-)

You might want to check out, test and review #14151 if you have access to MSVC. That would be awesome!
Mr-Leshiy commented at 12:43 AM on January 6, 2019: contributor

@practicalswift thank you. Of course, i will check it.
laanwj merged this on Jan 7, 2019
laanwj closed this on Jan 7, 2019
laanwj referenced this in commit f0fa6bad00 on Jan 7, 2019
linuxsh2 referenced this in commit a6e4d971d3 on Sep 16, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#15049 The project "libbitcoin_server" can not load successfully in VS2017