build: Drop macports support #15175

pull Empact wants to merge 1 commits into bitcoin:master from Empact:drop-macports changing 2 files +0 −17
  1. Empact commented at 9:09 am on January 16, 2019: member

    It’s unmaintained, according to @theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

    Alternative is to put it under CI. I don’t have a strong opinion on this, opened for separate consideration.

  2. fanquake added the label Build system on Jan 16, 2019
  3. laanwj commented at 10:20 am on January 16, 2019: member
    Concept ACK. If it’s unmaintained it should be removed, simple as that. Unless someone cares enough and promises to pick this up.
  4. DrahtBot commented at 11:10 am on January 16, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
    • #14920 (Build: enable -Wdocumentation via isystem by Empact)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. fanquake commented at 11:34 am on January 16, 2019: member
    Concept ACK. Doing this has been mentioned many times. Macports instructions were dropped from the macOS build readme in #4939 (>4 years ago, discussion in #4917), and I don’t think anyone has complained/asked to have them re-added.
  6. practicalswift commented at 3:52 pm on January 16, 2019: contributor

    Concept ACK

    Unsupported stuff should go.

  7. MarcoFalke added the label Needs gitian build on Jan 16, 2019
  8. MarcoFalke added this to the milestone 0.18.0 on Jan 16, 2019
  9. promag commented at 4:06 pm on January 16, 2019: member
    Concept ACK and change LGTM.
  10. laanwj commented at 5:08 pm on January 16, 2019: member
    “AppVeyor was unable to build non-mergeable pull request " huh
  11. build: Drop macports support 
    It's untested / unmaintained, according to theuni.
https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938
    4e81438f65
  12. Empact force-pushed on Jan 16, 2019
  13. Empact commented at 11:21 pm on January 16, 2019: member

    “AppVeyor was unable to build non-mergeable pull request " huh

    Rebasing cleared this up.

  14. jonasschnelli commented at 3:09 am on January 17, 2019: contributor
    Tested ACK 4e81438f6556d059923f07409264c11c41cc4a0b
  15. Empact commented at 3:18 am on January 17, 2019: member
    This also removes the last remaining references to qt4 :P
  16. DrahtBot commented at 11:15 am on January 17, 2019: member

    Gitian builds for commit fcb6694a9945d2a02f40587e18bd395ef64048e0 (master):

    Gitian builds for commit 823929563fbd52b8c9aca6af2d479c8ca183f51a (master and this pull):

  17. DrahtBot removed the label Needs gitian build on Jan 17, 2019
  18. IlyasRidhuan commented at 5:42 am on January 18, 2019: none
    utAck
  19. fanquake commented at 5:43 am on January 18, 2019: member
    utACK 4e81438
  20. theuni commented at 10:37 pm on January 18, 2019: member
    utACK 4e81438f6556d059923f07409264c11c41cc4a0b. Thanks!
  21. jonasschnelli merged this on Jan 19, 2019
  22. jonasschnelli closed this on Jan 19, 2019
  23. jonasschnelli referenced this in commit f55808ad69 on Jan 19, 2019
  24. rex4539 commented at 8:08 am on January 19, 2019: contributor

    For the poor soul that may come here in the future, trying to compile using MacPorts.

    Add the following to your Bash .profile:

    0export BDB_CFLAGS=/opt/local/include/db48/
1export CPPFLAGS="$CPPFLAGS -isystem /opt/local/include"
2export LIBS="$LIBS -L/opt/local/lib"
3export CPPFLAGS="$CPPFLAGS -I/opt/local/include/db48"
4export LIBS="$LIBS -L/opt/local/lib/db48"

    Restart your shell.

    Bitcoin Core will now compile.

  25. Empact deleted the branch on Jan 19, 2019
  26. jasonbcox referenced this in commit fa51353081 on Oct 17, 2020
  27. random-zebra referenced this in commit fbebade1e4 on Jun 11, 2021
  28. PastaPastaPasta referenced this in commit e203d8127f on Jun 26, 2021
  29. PastaPastaPasta referenced this in commit 5f9fe2d5d2 on Jun 26, 2021
  30. PastaPastaPasta referenced this in commit 12fe79134c on Jun 27, 2021
  31. PastaPastaPasta referenced this in commit 57813fa9a6 on Jun 28, 2021
  32. fanquake referenced this in commit 05cdceb19d on Nov 25, 2021
  33. fanquake referenced this in commit 111c3e06b3 on Nov 26, 2021
  34. sidhujag referenced this in commit e3472d86d5 on Nov 26, 2021
  35. MarcoFalke locked this on Dec 16, 2021


Empact laanwj DrahtBot fanquake practicalswift promag jonasschnelli IlyasRidhuan theuni rex4539

Labels
Build system

Milestone
0.18.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me