wallet: Use fsbridge::ifstream to fix Windows path issue #15468

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:win-wallet-fix changing 2 files +3 −1
  1. ken2812221 commented at 3:46 pm on February 23, 2019: contributor
    Fix #15460
  2. wallet: Use fsbridge::ifstream to fix Windows path issue 6ad79cbd56
  3. fanquake added the label Wallet on Feb 24, 2019
  4. fanquake added the label Windows on Feb 24, 2019
  5. ken2812221 commented at 12:53 pm on February 24, 2019: contributor
    image
  6. MarcoFalke added this to the milestone 0.18.0 on Feb 24, 2019
  7. laanwj commented at 8:41 am on February 25, 2019: member
    utACK 6ad79cbd562d04ebbcb61c774fb3389e70fedb7c
  8. MarcoFalke added the label Needs gitian build on Feb 25, 2019
  9. ryanofsky approved
  10. ryanofsky commented at 10:45 pm on February 25, 2019: member
    utACK 6ad79cbd562d04ebbcb61c774fb3389e70fedb7c. I was going to suggest that maybe there should be a linter only allowing use of fsbridge::ifstream, and not other ifstream classes. But this might be too strict because in a lot of cases we can know that filename being opened is ascii.
  11. DrahtBot commented at 9:37 am on February 26, 2019: member

    Gitian builds for commit b4fc5257b7dc106ff210d170397d4ce0e024f2c0 (master):

    Gitian builds for commit fef7c84b5f7fbda799c55888f05fd7f06d5e5705 (master and this pull):

  12. DrahtBot removed the label Needs gitian build on Feb 26, 2019
  13. fanquake commented at 11:23 pm on February 26, 2019: member
    utACK 6ad79cb
  14. laanwj commented at 11:04 am on February 27, 2019: member

    I was going to suggest that maybe there should be a linter only allowing use of fsbridge::ifstream, and not other ifstream classes.

    File system access should always go through the fsbridge when possible, this is better for sandboxing. So I think this would be appropriate, as well as mentioning this in the developer notes of course. (but not in this PR)

  15. laanwj merged this on Feb 27, 2019
  16. laanwj closed this on Feb 27, 2019
  17. laanwj referenced this in commit a4f9c024c6 on Feb 27, 2019
  18. deadalnix referenced this in commit 52d310b4a2 on Mar 24, 2020
  19. Munkybooty referenced this in commit 552bfa9133 on Sep 8, 2021
  20. PastaPastaPasta referenced this in commit 1abaa0a0a1 on Sep 11, 2021
  21. MarcoFalke locked this on Dec 16, 2021


ken2812221 laanwj ryanofsky DrahtBot fanquake

Labels
Wallet Windows

Milestone
0.18.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-01 13:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me