[rpc] remove deprecated generate method #15492

1. 
   Sjors commented at 9:34 am on February 27, 2019: member

   As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19.

   Clients should transition to using the node rpc method generatetoaddress.

2. fanquake added the label RPC/REST/ZMQ on Feb 27, 2019
3. fanquake added this to the milestone 0.19.0 on Feb 27, 2019
4. Sjors force-pushed on Feb 27, 2019
5. Sjors force-pushed on Feb 27, 2019
6. Sjors force-pushed on Feb 27, 2019
7. 
   DrahtBot commented at 11:49 am on February 27, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15150 (gui: Show wallet selector on console window if there are wallets loaded by promag)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   laanwj commented at 2:06 pm on February 27, 2019: member

   Nice cleanup. utACK.
9. in src/wallet/rpcwallet.cpp:3361 in 5e0d4fbfb9 outdated

   3357@@ -3358,62 +3358,6 @@ static UniValue bumpfee(const JSONRPCRequest& request)
   3358     return result;
   3359 }
   3360 
   3361-UniValue generate(const JSONRPCRequest& request)
   

   ---

   ---

   

   jnewbery commented at 4:15 pm on February 27, 2019:

   I expect you can also remove the #include <rpc/mining.h> include from this file.

   ---

   

   Sjors commented at 4:41 pm on February 27, 2019:

   Done
10. in test/functional/rpc_deprecated.py:7 in 5e0d4fbfb9 outdated

    3@@ -4,13 +4,13 @@
    4 # file COPYING or http://www.opensource.org/licenses/mit-license.php.
    5 """Test deprecation of RPC calls."""
    6 from test_framework.test_framework import BitcoinTestFramework
    7-from test_framework.util import assert_raises_rpc_error
    8+# from test_framework.util import assert_raises_rpc_error
    

    ---

    ---

    

    jnewbery commented at 4:17 pm on February 27, 2019:

    Rather than change this file around, can you just revert it to how it was pre-commit c9f02955b2e9062808a9455c4ee7d52cf401eef5.

    ---

    

    Sjors commented at 4:39 pm on February 27, 2019:

    Main reason for changing this file around is improving documentation; generate allows a much simpler example than createmultisig.

    Update: removed the skip_test_if_missing_module bit, since that’s wallet specific.

11. 
    jnewbery commented at 4:26 pm on February 27, 2019: member

    This should be marked as WIP and not merged before the 0.18 branch split.

    I agree that this should go in before #15492.

12. [rpc] remove deprecated generate method 8bb3e4c487
13. Sjors force-pushed on Feb 27, 2019
14. 
    Sjors commented at 4:41 pm on February 27, 2019: member

    Why WIP? That seems more appropriate for more experimental code. This PR is already tagged 0.19 so that should be clear enough.
15. 
    jnewbery commented at 4:50 pm on February 27, 2019: member

    Tagging 0.19 is fine. Just as long as the maintainers are aware that this shouldn’t be merged prior to the branch split.
16. 
    ryanofsky commented at 5:13 pm on February 27, 2019: member

    This PR seems reasonable, but I would like to remove:

    Removal helps with separating the wallet from the node in #15288

    from the PR description. I don’t think this is true in any significant sense. If there really is a need to relate this PR to #15288, you could say:

    Removal means that the interfaces::Chain class no longer needs to have a generateBlocks method added in #15288

    I think there is some confusion in the #15288 discussion that generateBlocks method requires additional makefile changes that other Chain methods don’t require, but this is not true. The only reason makefile changes are part of the generateBlocks commit is because that commit comes first, so all the later commits just piggyback off of it.

17. 
    Sjors commented at 6:36 pm on February 27, 2019: member

    @ryanofsky I removed that comment
18. ryanofsky approved
19. 
    ryanofsky commented at 7:34 pm on February 28, 2019: member

    utACK 8bb3e4c487500a580e3e18791b1f4e7dcdd35442, looks good to merge after the branch
20. 
    practicalswift commented at 8:41 pm on February 28, 2019: contributor

    GetScriptForMining is unused after the removal of generate.

    I suggest getting rid of it! :-)

21. [wallet] remove unused GetScriptForMining 07cae5287c
22. MarcoFalke referenced this in commit 9e3122de05 on Mar 2, 2019
23. 
    MarcoFalke commented at 2:44 pm on March 2, 2019: member

    ACK
24. MarcoFalke merged this on Mar 2, 2019
25. MarcoFalke closed this on Mar 2, 2019

    ---

26. Sjors deleted the branch on Mar 2, 2019
27. jasonbcox referenced this in commit 1ad604ee3e on Jun 30, 2020
28. Munkybooty referenced this in commit 1dbec74906 on Sep 8, 2021
29. vijaydasmp referenced this in commit 8946b234a8 on Nov 13, 2021
30. vijaydasmp referenced this in commit ad50aa6e53 on Nov 13, 2021
31. vijaydasmp referenced this in commit 7cad30a2e8 on Nov 13, 2021
32. vijaydasmp referenced this in commit d35e91c0e4 on Nov 15, 2021
33. vijaydasmp referenced this in commit e0db284dd9 on Nov 15, 2021
34. vijaydasmp referenced this in commit 73c36480c4 on Nov 16, 2021
35. vijaydasmp referenced this in commit 51ccd6a5f0 on Nov 22, 2021
36. MarcoFalke locked this on Dec 16, 2021

Contributors
Sjors DrahtBot laanwj jnewbery ryanofsky practicalswift MarcoFalke

Labels
RPC/REST/ZMQ

Milestone
0.19.0