doc: Move wallet lock annotations to header #15530

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1902-walletLocks changing 2 files +33 −34

MarcoFalke commented at 9:03 PM on March 4, 2019: member

We put the annotations in a central place (the header) as opposed to spreading them over the cpp files, where they easily get outdated.
doc: Move wallet lock annotations to header faebd2ef40
MarcoFalke added the label Refactoring on Mar 4, 2019
MarcoFalke added the label Wallet on Mar 4, 2019
practicalswift commented at 9:12 PM on March 4, 2019: contributor
utACK faebd2ef40bf6c9209110ad4e229e5a207b9c9da

Related lock annotation PRs that reviewers might be interested in:
- #15192: Add missing cs_main locks in ThreadImport(...)/Shutdown(...)/gettxoutsetinfo(...)/InitScriptExecutionCache(). Add missing locking annotations.
- #15191: validation: Add missing cs_{LastBlockFile,nBlockSequenceId} locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations.
promag commented at 3:09 PM on March 5, 2019: member

utACK faebd2ef40bf6c9209110ad4e229e5a207b9c9da.

in src/wallet/wallet.cpp:4127 in faebd2ef40

4123 | @@ -4125,7 +4124,7 @@ std::shared_ptr<CWallet> CWallet::CreateWalletFromFile(interfaces::Chain& chain,
4124 |          }
4125 |      }
4126 |  
4127 | -    int prev_version = walletInstance->nWalletVersion;
4128 | +    int prev_version = walletInstance->GetVersion();

ryanofsky commented at 7:49 PM on March 6, 2019:

Note: This GetVersion call looks like only change in this PR that actually affects locking behavior (GetVersion() call below just acquires cs_wallet recursively).

ryanofsky commented at 7:50 PM on March 6, 2019: member

utACK faebd2ef40bf6c9209110ad4e229e5a207b9c9da. Simple cs_wallet cleanup.
Empact commented at 4:28 PM on March 7, 2019: member

utACK faebd2ef40bf6c9209110ad4e229e5a207b9c9da
MarcoFalke merged this on Mar 7, 2019
MarcoFalke closed this on Mar 7, 2019
MarcoFalke referenced this in commit 726d0668ff on Mar 7, 2019
MarcoFalke deleted the branch on Mar 7, 2019
vijaydasmp referenced this in commit a6a9de6357 on Oct 27, 2021
vijaydasmp referenced this in commit 7f60ec6859 on Oct 29, 2021
vijaydasmp referenced this in commit d1fefb43d3 on Oct 30, 2021
vijaydasmp referenced this in commit b294d4165f on Nov 2, 2021
vijaydasmp referenced this in commit d0c5398007 on Nov 7, 2021
vijaydasmp referenced this in commit c534e99da1 on Nov 9, 2021
vijaydasmp referenced this in commit 14e1c76d56 on Nov 9, 2021
vijaydasmp referenced this in commit 26017122f4 on Nov 11, 2021
vijaydasmp referenced this in commit cfddaed9e2 on Nov 12, 2021
vijaydasmp referenced this in commit e303cf5fa8 on Nov 13, 2021
vijaydasmp referenced this in commit 9836a6dfaa on Nov 14, 2021
vijaydasmp referenced this in commit e7d85d062f on Nov 14, 2021
vijaydasmp referenced this in commit b41e46416f on Nov 16, 2021
vijaydasmp referenced this in commit ade3f5bcbc on Nov 16, 2021
vijaydasmp referenced this in commit 828167abb0 on Nov 17, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels