Comment for seemingly duplicate LIBBITCOIN_SERVER #15683

pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:patch-1 changing 1 files +2 −0

Bushstar commented at 7:19 AM on March 28, 2019: contributor

Added a comment to explain the addition of LIBBITCOIN_SERVER twice in bitcoind_LDADD which seems incorrect at a glance until the behaviour of Linux linkers is understood.
practicalswift commented at 8:06 AM on March 28, 2019: contributor

ACK 05df24e0a8fbfee2c33a3cc4f0a7e753f7141cdc

Thanks for documenting this!

Nice first-time contribution. Hope to see additional contributions from you!
scravy commented at 8:16 AM on March 28, 2019: contributor

ACK 05df24e
fanquake assigned fanquake on Mar 28, 2019
fanquake unassigned fanquake on Mar 28, 2019
fanquake added the label Docs on Mar 28, 2019
MarcoFalke commented at 1:33 PM on March 28, 2019: member

ACK 05df24e0a8fbfee2c33a3cc4f0a7e753f7141cdc

in src/Makefile.am:501 in 05df24e0a8 outdated

 496 | @@ -497,6 +497,10 @@ if TARGET_WINDOWS
 497 |  bitcoind_SOURCES += bitcoind-res.rc
 498 |  endif
 499 |  
 500 | +# LIBBITCOIN_SERVER added twice intentionally. Our libs are static and have circular
 501 | +# dependencies, Linux linkers which process libraries in command line order and only

ryanofsky commented at 2:37 PM on March 28, 2019:

The second sentence here isn't grammatical and is hard to understand (I'm not even sure it makes sense). Would replace this with a shorter comment and a link.

# Libraries below may be listed more than once to resolve circular dependencies (see
# https://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking#circular-dependency)

Bushstar commented at 2:50 PM on March 28, 2019: contributor

Updated the comment with @ryanofsky suggested text and link to make it more succinct and allow people to get more information.
MarcoFalke commented at 2:52 PM on March 28, 2019: member

Please squash trivial fixups to make this ready for review (according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits)
Comment for seemingly duplicate LIBBITCOIN_SERVER 2a1408c3ec
Bushstar force-pushed on Mar 28, 2019
Bushstar commented at 3:34 PM on March 28, 2019: contributor

@MarcoFalke commits squashed.
practicalswift commented at 4:18 PM on March 28, 2019: contributor

ACK 2a1408c3ec036d9f89c4241689cd16f26093b209
MarcoFalke commented at 5:37 PM on March 28, 2019: member

ACK 2a1408c
fanquake commented at 9:50 AM on March 29, 2019: member

utACK 2a1408c
ryanofsky approved
ryanofsky commented at 4:40 PM on March 29, 2019: member

utACK 2a1408c3ec036d9f89c4241689cd16f26093b209
pull[bot] referenced this in commit 0baf4b1f96 on Mar 29, 2019
MarcoFalke merged this on Mar 29, 2019
MarcoFalke closed this on Mar 29, 2019
Munkybooty referenced this in commit bb275da875 on Sep 22, 2021
Munkybooty referenced this in commit 0a56f434fd on Sep 27, 2021
Munkybooty referenced this in commit 6199e1ac95 on Sep 27, 2021
Munkybooty referenced this in commit 1132d77f2d on Sep 27, 2021
Munkybooty referenced this in commit 6c2784648c on Sep 30, 2021
Munkybooty referenced this in commit eb4643d674 on Oct 1, 2021
Munkybooty referenced this in commit 97775c22fe on Oct 1, 2021
kittywhiskers referenced this in commit 749a5ea12b on Oct 12, 2021
pravblockc referenced this in commit 87e5adeb7c on Nov 18, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels