The original ORCHID prefix was deprecated as of 2014-03, the new
ORCHIDv2 prefix was allocated by RFC7343 as of 2014-07. We did not
consider the original ORCHID prefix routable, and I don't see any reason
to consider the new one to be either.
Would like to know if people think this kind of thing is even worth keeping the codebase updated for. Perhaps it'd be nice to write a devtool to pull the csv from here and generate the code.
utACK 8be3f3063
Maybe we should instead just have a single IsUnroutable function that tests for all these cases simultaneously. Perhaps it just has a const vector of prefixes to check against.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
No conflicts as of last run.
utACK 00a50a09eaf9149e44c207290ec093fc86f4b096
Maybe we should instead just have a single IsUnroutable function that tests for all these cases simultaneously. Perhaps it just has a const vector of prefixes to check against.
Here's a take on that: https://github.com/bitcoin/bitcoin/compare/master...Empact:is-routable?expand=1
The original ORCHID prefix was deprecated as of 2014-03, the new
ORCHIDv2 prefix was allocated by RFC7343 as of 2014-07. We did not
consider the original ORCHID prefix routable, and I don't see any reason
to consider the new one to be either.
Rebased, I think I'm going to limit this change to just ORCHIDv2 for now.
utACK 8be3f306338e27b3fa3ad3bfb75f822d038909a5. Only change since last review is rebasing after #15718 merge.
re: #15689 (comment)
I think I'm going to limit this change to just ORCHIDv2 for now.
I was initially confused by this comment because this PR was always limited to ORCHIDv2. But this is just a response to an earlier comment about potentially expanding the PR: #15689 (comment)
Maybe we should instead just have a single IsUnroutable function that tests for all these cases simultaneously. Perhaps it just has a const vector of prefixes to check against.
Good idea but can be done separately.