depends: add ability to skip building zeromq #16089

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends_no_zeromq_one changing 4 files +15 −1
  1. fanquake commented at 4:19 pm on May 25, 2019: member

    Similar to other depends packages, add the ability to skip building zeromq by passing NO_ZMQ=1.

    Fixes #15918.

  2. depends: add ability to skip building zeromq c995c870aa
  3. fanquake added the label Build system on May 25, 2019
  4. fanquake added the label Needs gitian build on May 25, 2019
  5. fanquake requested review from dongcarl on May 25, 2019
  6. practicalswift commented at 9:30 am on May 26, 2019: contributor

    utACK c995c870aa4cc9b9ddf0a84ce15c544757a43a18

    Thanks for fixing this!

  7. DrahtBot commented at 2:37 am on May 27, 2019: member

    Gitian builds for commit e043bfce684f84bca413518a8452b3207123a031 (master):

    Gitian builds for commit 3e4c44d2ef3ae36ffb84346bf56603f58c2e89e9 (master and this pull):

  8. DrahtBot removed the label Needs gitian build on May 27, 2019
  9. Empact commented at 8:23 pm on May 27, 2019: member
    Concept ACK
  10. in depends/Makefile:108 in c995c870aa 
    104@@ -103,6 +105,10 @@ ifneq ($(qt_packages_),)
105 native_packages += $(qt_native_packages)
106 endif
107 
108+ifneq ($(zmq_packages_),)
    dongcarl commented at 8:46 pm on May 28, 2019:
    Would it work if you removed this ifneq and tacked $(zmp_packages_) on to the end of that long packages += line on line 101?
  11. jonasschnelli commented at 6:59 am on May 29, 2019: contributor
    utACK c995c870aa4cc9b9ddf0a84ce15c544757a43a18
  12. laanwj commented at 11:32 am on May 29, 2019: member

    Tested ACK c995c870aa4cc9b9ddf0a84ce15c544757a43a18

    • NO_ZMQ=1 correctly builds the dependencies without zmq (and doesn’t download zmq source)
    • Without NO_ZMQ fetches and builds ZMQ as before

    Just for info, ARM executable size with/without zmq:

    0-rwxr-xr-x 1 user user 6868356 May 29 13:31 src/bitcoind
1-rwxr-xr-x 1 user user 6138992 May 29 13:23 src/bitcoind.nozmq
  13. pull[bot] referenced this in commit 12ba656de3 on May 29, 2019
  14. laanwj merged this on May 29, 2019
  15. laanwj closed this on May 29, 2019
  16. fanquake deleted the branch on May 30, 2019
  17. laanwj referenced this in commit a8f5d5c6b9 on Dec 7, 2019
  18. sidhujag referenced this in commit 8b5b208c0b on Dec 7, 2019
  19. deadalnix referenced this in commit 19ea95224a on Apr 1, 2020
  20. ftrader referenced this in commit cb31f4509d on Aug 17, 2020
  21. sidhujag referenced this in commit 4992c54713 on Nov 10, 2020
  22. Munkybooty referenced this in commit c504d40db7 on Oct 17, 2021
  23. Munkybooty referenced this in commit 11e17c0cd0 on Oct 25, 2021
  24. Munkybooty referenced this in commit 0ed99917e3 on Oct 26, 2021
  25. Munkybooty referenced this in commit 9b2be1359c on Oct 26, 2021
  26. Munkybooty referenced this in commit bd4f568117 on Nov 9, 2021
  27. pravblockc referenced this in commit fa7ed800f8 on Nov 18, 2021
  28. DrahtBot locked this on Dec 16, 2021


fanquake practicalswift DrahtBot Empact dongcarl jonasschnelli laanwj

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-05 01:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me