wallet: Refactor: Update NULL -> nullptr #16147

pull mxaddict wants to merge 1 commits into bitcoin:master from mxaddict:patch-1 changing 1 files +1 −1

mxaddict commented at 10:58 AM on June 5, 2019: contributor

I noticed most CPP code already use nullptr

#16146 replacement PR
Updated more NULL -> nullptr 89bd27259b
MarcoFalke renamed this:
~~Updated more NULL -> nullptr~~
wallet: Refactor: Update NULL -> nullptr
on Jun 5, 2019
Empact commented at 11:14 AM on June 5, 2019: member

See also #13802 and #15112, which automatically enforces against such cases.
fanquake added the label Refactoring on Jun 5, 2019
laanwj commented at 1:21 PM on June 5, 2019: member

ACK after this can be automatically avoided (e.g. by a linter) from here on, I dont' like an infinite stream of these PRs.
mxaddict commented at 2:49 PM on June 5, 2019: contributor

Also moved some changes from #16146 over to https://github.com/bitcoin-core/univalue/pull/18
practicalswift commented at 11:13 PM on June 5, 2019: contributor

utACK 89bd27259bb898066a2e1616f94d3df0fe0d0b8f

+1 for guarding against introduction of NULL via linting or a compiler warning (#15112 ready for merge?)
PastaPastaPasta approved
PastaPastaPasta commented at 2:56 AM on June 6, 2019: contributor

ACK
fanquake approved
fanquake commented at 8:39 AM on June 7, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/16147/commits/89bd27259bb898066a2e1616f94d3df0fe0d0b8f

after this can be automatically avoided (e.g. by a linter) from here on, I dont' like an infinite stream of these PRs.

👍
promag commented at 9:55 AM on June 9, 2019: member

This is already done in #15112, IMO should be closed - either way ACK 89bd27259bb898066a2e1616f94d3df0fe0d0b8f.
MarcoFalke commented at 6:49 AM on June 10, 2019: member
Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:
- Time spent on review
- Accidental introduction of bugs
- (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.
For more information about refactoring changes and stylistic cleanup, see
Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

Let me know if you have any questions.
MarcoFalke closed this on Jun 10, 2019
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16146 Updated more NULL -> nullptr